From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: Dmitry <dbaryshkov@gmail.com>,
linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
hskinnemoen@atmel.com, domen.puncer@telargo.com,
lethal@linux-sh.org, tony@atomide.com, paul@pwsan.com
Subject: Re: [PATCH 1/3] Clocklib: add generic framework for managing clocks.
Date: Thu, 27 Mar 2008 09:18:10 +0000 [thread overview]
Message-ID: <20080327091810.GA32396@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20080327100623.34d92c84@hskinnemo-gx620.norway.atmel.com>
On Thu, Mar 27, 2008 at 10:06:23AM +0100, Haavard Skinnemoen wrote:
> > + int users;
>
> Reference counting, probably need that too.
>
> > + unsigned long rate;
>
> This one is redundant. Use getrate() instead.
... which means a separate getrate() functions for every clock. Not really
practical for PXA.
> > + int delay;
>
> Huh? A delay after enabling the clock? Why can't the enable() hook do
> that if it's really necessary?
... which means a separate enable() function for each clock. The delay
there has not a lot to do with the actual register you're frobbing, but
the resy of the SoC. So, again, not really practical for PXA.
The result for PXA is a tradeoff between reducing the data size and
increasing the text size, or increasing the data size and keeping
the existing data size.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of:
next prev parent reply other threads:[~2008-03-27 9:18 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 15:49 [PATCH 0/3] Clocklib: generic clocks framework Dmitry Baryshkov
2008-03-26 15:52 ` [PATCH 1/3] Clocklib: add generic framework for managing clocks Dmitry Baryshkov
2008-03-26 16:04 ` Haavard Skinnemoen
2008-03-26 16:14 ` Paul Mundt
2008-03-26 17:04 ` Dmitry
2008-03-26 20:09 ` Russell King
2008-03-26 16:52 ` Dmitry
2008-03-26 17:44 ` Paul Mundt
2008-03-27 9:52 ` Dmitry
2008-03-26 17:44 ` Juergen Beisert
2008-03-27 9:06 ` Haavard Skinnemoen
2008-03-27 9:18 ` Russell King [this message]
2008-03-27 9:26 ` Haavard Skinnemoen
2008-03-27 9:33 ` Russell King
2008-03-27 9:50 ` Paul Mundt
2008-03-27 9:53 ` Haavard Skinnemoen
2008-03-27 10:08 ` Dmitry
2008-03-27 10:20 ` Haavard Skinnemoen
2008-03-27 13:33 ` Dmitry
2008-03-27 9:29 ` pHilipp Zabel
2008-03-27 9:36 ` Russell King
2008-03-28 14:23 ` Pavel Machek
2008-03-29 12:36 ` Haavard Skinnemoen
2008-03-26 15:52 ` [PATCH 2/3] Clocklib: debugfs support Dmitry Baryshkov
2008-03-26 15:53 ` [PATCH 3/3] Clocklib: support sa1100 sub-arch Dmitry Baryshkov
2008-03-26 16:17 ` [PATCH 4/4] Clocklib: support ARM pxa sub-arch Dmitry Baryshkov
-- strict thread matches above, loose matches on Subject: below --
2008-06-26 12:50 [PATCH 0/3] Clocklib: generic framework for clocks managing [v3] Dmitry Baryshkov
2008-06-26 12:51 ` [PATCH 1/3] Clocklib: add generic framework for managing clocks Dmitry Baryshkov
2008-06-26 15:00 ` pHilipp Zabel
2008-06-26 15:03 ` Dmitry Baryshkov
2008-07-03 20:31 ` Ben Dooks
2008-07-04 8:44 ` Pavel Machek
2008-07-04 9:04 ` Dmitry Baryshkov
2008-07-04 9:12 ` Haavard Skinnemoen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080327091810.GA32396@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dbaryshkov@gmail.com \
--cc=domen.puncer@telargo.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=hskinnemoen@atmel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox