From: Oliver Neukum <oliver@neukum.org>
To: Brad Sawatzky <brad+kernel@swatter.net>
Cc: Alan Stern <stern@rowland.harvard.edu>,
Greg Kroah-Hartman <gregkh@suse.de>,
linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH] usb-serial: fix regression in Visor/Palm OS module for kernels >= 2.6.24
Date: Thu, 27 Mar 2008 09:56:36 +0100 [thread overview]
Message-ID: <200803270956.36892.oliver@neukum.org> (raw)
In-Reply-To: <20080327050725.GC11011@enigma.swatter.net>
Am Donnerstag, 27. März 2008 06:07:26 schrieb Brad Sawatzky:
> FWIW, another option I considered was patching the test added in commit
> 063a2da8f01806906f7d7b1a1424b9afddebc443 to use '<=' instead of '!=' in the
> obvious places. That is, test if the usb-serial subsystem reports at least
> as many endpoints as the device definition "requires" rather than checking
The problem with that is that if a device adds an endpoint we may use
the wrong endpoints in drivers, depending on how the endpoints in devices
are numbered. As we have no idea what the consequences would be, we rather
fail cleanly.
Regards
Oliver
prev parent reply other threads:[~2008-03-27 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-26 2:32 [PATCH] usb-serial: fix regression in Visor/Palm OS module for kernels >= 2.6.24 Brad Sawatzky
2008-03-26 7:17 ` Oliver Neukum
2008-03-27 0:15 ` Brad Sawatzky
2008-03-27 2:55 ` Alan Stern
2008-03-27 5:07 ` Brad Sawatzky
2008-03-27 6:41 ` Charles Banas
2008-03-27 8:56 ` Oliver Neukum [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200803270956.36892.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=brad+kernel@swatter.net \
--cc=gregkh@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox