From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757525AbYC0Lh4 (ORCPT ); Thu, 27 Mar 2008 07:37:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755769AbYC0Lhs (ORCPT ); Thu, 27 Mar 2008 07:37:48 -0400 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:39617 "EHLO gprs189-60.eurotel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755479AbYC0Lhr (ORCPT ); Thu, 27 Mar 2008 07:37:47 -0400 Date: Thu, 27 Mar 2008 10:59:49 +0100 From: Pavel Machek To: Ingo Molnar Cc: Andi Kleen , kernel list , Greg KH , "Rafael J. Wysocki" Subject: Re: iommu breaks usb after resume Message-ID: <20080327095949.GA5771@elf.ucw.cz> References: <20080320111429.GA14764@elf.ucw.cz> <20080321135418.GB2346@one.firstfloor.org> <20080326102151.GB18965@elf.ucw.cz> <20080326130052.GF2170@one.firstfloor.org> <20080326225407.GA9378@elf.ucw.cz> <20080326230017.GA21017@elte.hu> <20080327084231.GC25876@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080327084231.GC25876@elf.ucw.cz> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi! > > * Pavel Machek wrote: > > > > > @@ -733,8 +735,8 @@ static struct pci_driver agp_amd64_pci_d > > > .probe = agp_amd64_probe, > > > .remove = agp_amd64_remove, > > > #ifdef CONFIG_PM > > > - .suspend = agp_amd64_suspend, > > > - .resume = agp_amd64_resume, > > > + .suspend_late = agp_amd64_suspend, > > > + .resume_early = agp_amd64_resume, > > > #endif > > > > ah, makes sense. I've queued up your fix in x86.git (sans the debug > > printks), please send your signoff once you can verify that it solves > > the hibernation hang on your box and we'll push it into 2.6.25. > > You have my signed-off from previous email, but... > > it does not solve a problem here -- see the mail to andi. It may still > be good idea to take it (but I do not think it should go to 2.6.25), > but may machine still does not work. No, I do not think problems are in drivers/char/agp... end of aperture_64.c: /* Fix up the north bridges */ for (num = 24; num < 32; num++) { if (!early_is_k8_nb(read_pci_config(0, num, 3, 0x00))) continue; /* * Don't enable translation yet. That is done later. * Assume this BIOS didn't initialise the GART so * just overwrite all previous bits */ write_pci_config(0, num, 3, 0x90, aper_order<<1); write_pci_config(0, num, 3, 0x94, aper_alloc>>25); } } ...this sounds like it needs to be done during resume, too, no? Where's the other part? "Don't enable translation yet"? What enables the translation? Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html pomozte zachranit klanovicky les: http://www.ujezdskystrom.info/