From: Andrew Morton <akpm@linux-foundation.org>
To: dougthompson@xmission.com
Cc: dougthompson@xmission.com, alan@lxorguk.ukuu.org.uk,
linux-kernel@vger.kernel.org, Hitoshi Mitake <h.mitake@gmail.com>
Subject: Re: [PATCH 2/3] EDAC Fix module initialization on several modules
Date: Thu, 27 Mar 2008 14:17:49 -0700 [thread overview]
Message-ID: <20080327141749.585fb35a.akpm@linux-foundation.org> (raw)
In-Reply-To: <47e17dda.Gkad5p5g8/aS4wLG%dougthompson@xmission.com>
On Wed, 19 Mar 2008 14:55:54 -0600
dougthompson@xmission.com wrote:
> From: Hitoshi Mitake <h.mitake@gmail.com>
>
> I implmented opstate_init() as a inline function in linux/edac.h .
>
> added calling opstate_init() to:
> i82443bxgx_edac.c
> i82860_edac.c
> i82875p_edac.c and
> i82975x_edac.c .
>
> I think modified sources are now polling well.
>
> Hitoshi
>
> This is a good refactor to reduce the initialization code to a single
> point of implementaton, and then just call that code from each of the
> modules to setup proper state
I futzed around for a while getting this to build with i386
allmodconfig but then got a bit tired of it.
Version 2, please ;)
prev parent reply other threads:[~2008-03-27 21:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-19 20:55 [PATCH 2/3] EDAC Fix module initialization on several modules dougthompson
2008-03-27 21:17 ` Andrew Morton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080327141749.585fb35a.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dougthompson@xmission.com \
--cc=h.mitake@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox