From: Dave Jones <davej@codemonkey.org.uk>
To: Adrian Bunk <bunk@kernel.org>
Cc: sfrench@samba.org, linux-cifs-client@lists.samba.org,
linux-kernel@vger.kernel.org
Subject: Re: cifs_mount() contains strange code
Date: Thu, 27 Mar 2008 17:53:40 -0400 [thread overview]
Message-ID: <20080327215340.GA27219@codemonkey.org.uk> (raw)
In-Reply-To: <20080327173458.GA32200@cs181133002.pp.htv.fi>
On Thu, Mar 27, 2008 at 07:34:58PM +0200, Adrian Bunk wrote:
> This looks somehow fishy (note the "rc" settings):
>
> <-- snip -->
>
> ...
> int
> cifs_mount(struct super_block *sb, struct cifs_sb_info *cifs_sb,
> char *mount_data, const char *devname)
> {
> ...
> /* BB check if this works for exactly length
> * three strings */
> if ((strchr(volume_info.UNC + 3, '\\') == NULL)
> && (strchr(volume_info.UNC + 3, '/') ==
> NULL)) {
> rc = connect_to_dfs_path(xid, pSesInfo,
> "", cifs_sb->local_nls,
> cifs_sb->mnt_cifs_flags &
> CIFS_MOUNT_MAP_SPECIAL_CHR);
> rc = -ENODEV;
> goto out;
>
> <-- snip -->
I've noticed a bunch of things like that from time to time, and wondered
how useful it would be to have sparse warn on double assignments of variables
without a read inbetween.
Dave
--
http://www.codemonkey.org.uk
prev parent reply other threads:[~2008-03-27 21:54 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-27 17:34 cifs_mount() contains strange code Adrian Bunk
2008-03-27 21:53 ` Dave Jones [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080327215340.GA27219@codemonkey.org.uk \
--to=davej@codemonkey.org.uk \
--cc=bunk@kernel.org \
--cc=linux-cifs-client@lists.samba.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sfrench@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox