Re: Kconfig RTC selection (was: 2.6.25-rc7: Ugh.)

Adrian Bunk
2008-03-28T22:36:59Z

On Fri, Mar 28, 2008 at 03:18:35PM -0700, David Brownell wrote:
> On Friday 28 March 2008, Adrian Bunk wrote:
>
> > > > grep for CONFIG_SUN_MOSTEK_RTC and you'll get the point.
> > >
> > > Right: it doesn't mention JS_RTC at all. Whatever is up
> > > with that stuff, it's broken.
> >
> > You miss the point, the point is:
> > drivers/sbus/char/Makefile:obj-$(CONFIG_SUN_MOSTEK_RTC) += rtc.o
> >
> > Two modules with the same name in one build are not allowed.
>
> It gets uglier and uglier. So if that abortion is really
> needed, it'd make more sense to rename the MOSTEK code.
> If that's not fixed, its Kconfig should mention needing
> the JS_RTC thing instead of the "real" legacy rtc.c ...

The Mostek code does not need drivers/char/rtc.c

JS_RTC is only needed for some unusual sparc machines.

> Glad I got rid of my JavaStation ages ago, but I liked
> the idea of having a real builtin coffee cup holder. :)
>...

I'm not sure, but the JavaStation might actually be one of these unusual
machines...

> - Dave

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed