Re: 2.6.25-rc7: Ugh.

Mark Lord
2008-03-28T13:48:14Z

David Brownell wrote:
> On Friday 28 March 2008, Ingo Molnar wrote:
>>>> Could somebody please fix the RTC mess in kconfig now ?
>>> My version has been sitting in MM for a while now.
>> could you please provide an URL or the patch itself so that others who
>> hit this issue and read this thread can apply the fix?
>
> I merged the two patches (gentle, then harsh) so the result is
> smaller. Here you go.
>
> - dave
>
>
> ========== CUT HERE
> Prevent the most significant RTC configuration problems:
>
> - If the new RTC framework is enabled, don't allow any of the
> legacy drivers to be configured.
>
> - When using generic RTC on x86, enable rtc-cmos by default.
>
> It seems too many people are used to enabling a legacy RTC despite
> the Kconfig help/comments; the gentle approach hasn't worked.
>
> Signed-off-by: David Brownell <dbrownell@users.sourceforge.net>
> ---
> drivers/char/Kconfig | 8 ++++++++
> drivers/rtc/Kconfig | 5 +----
> 2 files changed, 9 insertions(+), 4 deletions(-)
>
> --- linux-2.6.orig/drivers/char/Kconfig 2008-03-28 02:35:58.000000000 -0700
> +++ linux-2.6/drivers/char/Kconfig 2008-03-28 02:39:17.000000000 -0700
> @@ -704,6 +704,12 @@ config NVRAM
> To compile this driver as a module, choose M here: the
> module will be called nvram.
>
> +#
> +# These legacy RTC drivers just cause too many conflicts with the generic
> +# RTC framework ... let's not even try to coexist any more.
...

Thanks, David. Could you perhaps also update the option descriptions
to clearly indicate which set of RTCs are the new ones, and which are
the old ones that are going away someday?

I didn't find it at all obvious, and I still don't know which set my
configured kernel is actually using.

Thanks