From: Andi Kleen <andi@firstfloor.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Pavel Machek <pavel@ucw.cz>, Andi Kleen <andi@firstfloor.org>,
kernel list <linux-kernel@vger.kernel.org>
Subject: Re: agpgart: when telling user you'll corrupt his data, at least do it at KERN_CRIT
Date: Fri, 28 Mar 2008 15:25:29 +0100 [thread overview]
Message-ID: <20080328142529.GU29105@one.firstfloor.org> (raw)
In-Reply-To: <20080328141348.GE29218@elte.hu>
> yes that is the theory - but how did your disk get corrupted in
> practice? ;-)
I suspect after wakeup due to the wrong ordering in resume (agp resume function
called too late).
The IOMMU code unfortunately doesn't know that the GART has gone away.
The right fix for that is probably to move the GART resume code into
some shared file and make it a sysdev.
-Andi
next prev parent reply other threads:[~2008-03-28 14:22 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 11:25 agpgart: when telling user you'll corrupt his data, at least do it at KERN_CRIT Pavel Machek
2008-03-28 11:35 ` Andi Kleen
2008-04-01 12:24 ` agpgart: scary messages are fortunately obsolete Pavel Machek
2008-04-01 13:33 ` Andi Kleen
2008-04-04 8:55 ` Ingo Molnar
2008-03-28 11:35 ` agpgart: when telling user you'll corrupt his data, at least do it at KERN_CRIT Ingo Molnar
2008-03-28 12:48 ` Jiri Kosina
2008-03-28 12:51 ` Ingo Molnar
2008-03-28 13:44 ` Pavel Machek
2008-03-28 14:13 ` Ingo Molnar
2008-03-28 14:25 ` Andi Kleen [this message]
2008-04-01 12:13 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328142529.GU29105@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox