From: Andrew McNabb <amcnabb@mcnabbs.org>
To: Pavel Machek <pavel@suse.cz>
Cc: Rodney Lorrimar <rodney@rodney.id.au>,
jikos@suse.cz, linux-kernel@vger.kernel.org,
Benjamin Herrenschmidt <benh@kernel.crashing.org>
Subject: Re: [PATCH] Input: adbhid - fix capslock key state after suspend
Date: Fri, 28 Mar 2008 10:09:06 -0600 [thread overview]
Message-ID: <20080328160906.GA16187@mcnabbs.org> (raw)
In-Reply-To: <20080328105855.GA1686@elf.ucw.cz>
[-- Attachment #1: Type: text/plain, Size: 654 bytes --]
On Fri, Mar 28, 2008 at 11:58:55AM +0100, Pavel Machek wrote:
> On Fri 2008-03-28 01:15:56, Rodney Lorrimar wrote:
> > If the adbhid module parameter restore_capslock_events is used,
> > sometimes capslock will get stuck down after resuming.
>
> Hmmm, why does that need to be a parameter? I mean... can we just do
> the right thing?
I agree. There really don't seem to be any drawbacks to keeping track
of capslock state. The worst thing that can happen is that it somehow
occasionally fails to do the right thing.
--
Andrew McNabb
http://www.mcnabbs.org/andrew/
PGP Fingerprint: 8A17 B57C 6879 1863 DE55 8012 AB4D 6098 8826 6868
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-03-28 16:37 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 0:15 [PATCH] Input: adbhid - fix capslock key state after suspend Rodney Lorrimar
2008-03-28 10:58 ` Pavel Machek
2008-03-28 16:09 ` Andrew McNabb [this message]
2008-04-10 9:59 ` Rodney Lorrimar
2008-04-10 10:19 ` [PATCH] Input: adbhid - capslock and power button fix Rodney Lorrimar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080328160906.GA16187@mcnabbs.org \
--to=amcnabb@mcnabbs.org \
--cc=benh@kernel.crashing.org \
--cc=jikos@suse.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@suse.cz \
--cc=rodney@rodney.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox