Re: [PATCH 1/7] omfs: define filesystem structures

Bob Copeland
2008-03-28T23:19:09Z

On Fri, Mar 28, 2008 at 09:19:40PM +0100, Pavel Machek wrote:
> On Wed 2008-03-26 20:45:54, Bob Copeland wrote:
> > OMFS is a proprietary filesystem created for the ReplayTV and
> > also used by the Rio Karma. It uses hash tables with unordered,
> > unbounded lists in each bucket for directories, extents for
>
> Why did they create such beast?

Heh, I wish I knew. Good old NIH. There were so many "interesting"
decisions here, like requiring seeks all over the place for dir
traversal, picking a hash function that has collisions in almost every
bucket even when the table is half empty, wasting large amounts of space
by not even using 3/4s of certain blocks -- it's hard to pick a favorite.

Oh, on ReplayTV 4/5xxx they also byte-swapped the block layer such that
every 4 bytes were written backwards (even data). So a be64 would
be written out as 'le32_high le32_low'. This patch doesn't support that
brain damage, but I did cook up a bswap dm target to test with one of
those disk images.

> > +struct omfs_header {
> > + __be64 h_self;
> > + __be32 h_body_size;
> > + __be16 h_crc;
> > + char h_fill1[2];
> > + u8 h_version;
> > + char h_type;
> > + u8 h_magic;
> > + u8 h_check_xor;
> > + __be32 h_fill2;
> > +};
>
> attribute packed or something? Some strange machine (alpha?) may
> decide to align u8s at 32bit boundaries...

Thanks, I guess this applies for all the on disk structs.

--
Bob Copeland %% www.bobcopeland.com