* Re: [patch 20/21] forcedeth: fix locking bug with netconsole
[not found] ` <20080328164209.e8b723d8.akpm@linux-foundation.org>
@ 2008-03-28 23:46 ` Ingo Molnar
0 siblings, 0 replies; only message in thread
From: Ingo Molnar @ 2008-03-28 23:46 UTC (permalink / raw)
To: Andrew Morton; +Cc: Jeff Garzik, David Miller, netdev, aabdulla, linux-kernel
* Andrew Morton <akpm@linux-foundation.org> wrote:
> > > Please do not mix device driver changes with core networking
> > > changes.
> >
> > FWIW my plan was to snip the net/* stuff and only apply the
> > forcedeth portion.
> >
> > (leaving <whomever> to pick up the pieces, should they so desire)
> >
>
> Just drop 'em completely I'd say.
you mean the netpoll.c bits? sure.
> otoh, drivers do seem a bit flakey in the netpoll-support area, so a
> bit of extra debug wouldn't hurt. But checking irqs_disabled() either
> side of a udelay() was a bit paranoid ;)
yeah. i completely forgot about those bits. But lets make sure the
forcedeth.c fix gets into .25 - it's obvious and it fixes a nasty bug.
Without that fix netconsole is unusable on forcedeth.
Ingo
^ permalink raw reply [flat|nested] only message in thread