From: Paul Jackson <pj@sgi.com>
To: "Huang, Ying" <ying.huang@intel.com>
Cc: hpa@zytor.com, andi@firstfloor.org, mingo@redhat.com,
tglx@linutronix.de, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data
Date: Sat, 29 Mar 2008 23:25:10 -0500 [thread overview]
Message-ID: <20080329232510.b6d5e396.pj@sgi.com> (raw)
In-Reply-To: <1206672584.13404.25.camel@caritas-dev.intel.com>
Huang wrote:
> + __u32 payload_offset;
> + __u32 payload_length;
This seems to be the descriptor for an incoming compressed
kernel image, right? What is it doing in this patchset?
In your PATCH 4/4 to Documentation/i386/boot.txt, I can see
that there already existed documentation of these two payload
fields:
0248/4 2.08+ payload_offset Offset of kernel payload
024C/4 2.08+ payload_length Length of kernel payload
However, that documentation is just a useless rephrasing of the
variable names, with the added word "kernel". Is this a compressed
kernel image? If so, could that documentation be improved, perhaps as:
0248/4 2.08+ payload_offset Offset of compressed kernel payload
024C/4 2.08+ payload_length Length of compressed kernel payload
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.940.382.4214
next prev parent reply other threads:[~2008-03-30 4:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-28 2:49 [PATCH 2/4] x86_64 boot -v2: Add linked list of struct setup_data Huang, Ying
2008-03-30 4:25 ` Paul Jackson [this message]
2008-03-30 4:31 ` Paul Jackson
2008-03-31 0:54 ` Huang, Ying
2008-04-02 7:39 ` Paul Jackson
2008-04-02 16:39 ` H. Peter Anvin
2008-04-02 17:36 ` Paul Jackson
2008-03-30 8:15 ` Yinghai Lu
2008-03-31 0:52 ` Huang, Ying
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080329232510.b6d5e396.pj@sgi.com \
--to=pj@sgi.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox