From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756747AbYCaCG0 (ORCPT ); Sun, 30 Mar 2008 22:06:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753899AbYCaCGR (ORCPT ); Sun, 30 Mar 2008 22:06:17 -0400 Received: from relay1.sgi.com ([192.48.171.29]:36139 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752904AbYCaCGQ (ORCPT ); Sun, 30 Mar 2008 22:06:16 -0400 Date: Sun, 30 Mar 2008 21:06:14 -0500 From: Jack Steiner To: Yinghai Lu Cc: Andi Kleen , mingo@elte.hu, tglx@linutronix.de, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 8/8] x86_64: Support for new UV apic Message-ID: <20080331020613.GA20619@sgi.com> References: <20080328191216.GA16455@sgi.com> <86802c440803301622j2874ca56t51b52a54920a233b@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <86802c440803301622j2874ca56t51b52a54920a233b@mail.gmail.com> User-Agent: Mutt/1.4.2.2i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > so this is "the new one of Friday"? Yes, and it has the same bug although it is located in a slightly different place. A few minutes ago, I posted a patch to delete the extra lines. > Did you test it on non UV_X2APIC box? The code is clearly wrong. I booted on an 8p AMD box and had no problems. Apparently the kernel (at least basic booting) is not too sensitive to incorrect apicids being returned. Most critical-to-boot code must use apicids from the ACPI tables. However, the bug does affect numa node assignment. And probably other places, too. --- jack