From: Andi Kleen <andi@firstfloor.org>
To: Dave Airlie <airlied@gmail.com>
Cc: Andi Kleen <andi@firstfloor.org>,
Dave Airlie <airlied@redhat.com>,
linux-kernel@vger.kernel.org, tglx@linutronix.de,
mingo@redhat.com, arjan@linux.intel.com,
thomas@tungstengraphics.com
Subject: Re: [PATCH] x86: create array based interface to change page attribute
Date: Mon, 31 Mar 2008 13:46:46 +0200 [thread overview]
Message-ID: <20080331114646.GE29105@one.firstfloor.org> (raw)
In-Reply-To: <21d7e9970803310421k67f1a697s8ffb5a4eef71c605@mail.gmail.com>
On Mon, Mar 31, 2008 at 09:21:19PM +1000, Dave Airlie wrote:
> On Mon, Mar 31, 2008 at 5:25 PM, Andi Kleen <andi@firstfloor.org> wrote:
> > Dave Airlie <airlied@redhat.com> writes:
> > >
> > > +#define CPA_FLUSHTLB 1
> > > +#define CPA_ARRAY 2
> >
> > I don't think CPA_ARRAY should be a separate case. Rather single
> > page flushing should be an array with only a single entry. pageattr
> > is already very complex, no need to make add more special cases.
>
> I thought about this but the current interface takes a start address
> and number of pages from that point to cpa,
> the array interface takes an array of page sized pages.
>
> I don't really think we need to generate an array in the first case
> with all the pages in it..
Just put the length into the array members too.
-Andi
next prev parent reply other threads:[~2008-03-31 11:43 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-31 5:19 [PATCH] x86: create array based interface to change page attribute Dave Airlie
2008-03-31 6:54 ` Thomas Hellström
2008-03-31 9:33 ` Arjan van de Ven
2008-03-31 11:04 ` Thomas Hellström
2008-03-31 7:25 ` Andi Kleen
2008-03-31 7:55 ` Thomas Hellström
2008-03-31 8:38 ` Andi Kleen
2008-03-31 9:06 ` Thomas Hellström
2008-03-31 9:18 ` Andi Kleen
2008-03-31 11:10 ` Thomas Hellström
2008-03-31 16:08 ` Arjan van de Ven
2008-03-31 16:41 ` Thomas Hellström
2008-03-31 16:49 ` Arjan van de Ven
2008-03-31 17:26 ` Thomas Hellström
2008-04-01 20:58 ` Arjan van de Ven
2008-04-01 21:29 ` Thomas Hellström
2008-04-01 22:30 ` Arjan van de Ven
2008-04-02 6:30 ` Thomas Hellström
2008-04-02 6:35 ` Arjan van de Ven
2008-04-02 6:59 ` Thomas Hellström
2008-04-02 14:01 ` Arjan van de Ven
2008-04-02 17:57 ` Thomas Hellström
2008-04-07 18:23 ` Jesse Barnes
2008-04-07 19:51 ` Thomas Hellström
2008-04-07 19:59 ` Jesse Barnes
2008-04-07 20:46 ` Thomas Hellström
2008-04-07 20:57 ` Arjan van de Ven
2008-04-08 6:12 ` Thomas Hellström
2008-04-07 21:04 ` Jesse Barnes
2008-04-08 6:21 ` Thomas Hellström
2008-04-08 14:27 ` Jesse Barnes
2008-04-07 20:56 ` Arjan van de Ven
2008-04-07 21:02 ` Jesse Barnes
2008-04-07 21:09 ` Jesse Barnes
2008-03-31 9:56 ` Arjan van de Ven
2008-03-31 11:21 ` Dave Airlie
2008-03-31 11:46 ` Andi Kleen [this message]
2008-04-02 1:35 ` Dave Airlie
2008-04-01 18:20 ` Arjan van de Ven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080331114646.GE29105@one.firstfloor.org \
--to=andi@firstfloor.org \
--cc=airlied@gmail.com \
--cc=airlied@redhat.com \
--cc=arjan@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=thomas@tungstengraphics.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox