From: akepner@sgi.com
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Tony Luck <tony.luck@intel.com>,
Jesse Barnes <jbarnes@virtuousgeek.org>,
Jes Sorensen <jes@sgi.com>,
Randy Dunlap <randy.dunlap@oracle.com>,
Roland Dreier <rdreier@cisco.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
David Miller <davem@davemloft.net>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Grant Grundler <grundler@parisc-linux.org>,
Michael Ellerman <michael@ellerman.id.au>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 0/3 v5] dma: add dma_*map*_attrs() interfaces
Date: Mon, 31 Mar 2008 18:31:59 -0700 [thread overview]
Message-ID: <20080401013159.GA29410@sgi.com> (raw)
In-Reply-To: <20080327201843.4f5f983b.akpm@linux-foundation.org>
On Thu, Mar 27, 2008 at 08:18:43PM -0700, Andrew Morton wrote:
> On Wed, 19 Mar 2008 18:07:09 -0700 akepner@sgi.com wrote:
>
> alpha allmodconfig:
>
>
> In file included from include/asm/pci.h:7,
> from include/linux/pci.h:953,
> from include/asm/core_mcpcia.h:9,
> from include/asm/io.h:226,
> from arch/alpha/kernel/asm-offsets.c:11:
> include/linux/dma-mapping.h: In function 'dma_map_single_attrs':
> include/linux/dma-mapping.h:157: error: implicit declaration of function 'pci_map_single'
> ....
>
> We're in include hell, I think....
Yeah.
Alpha did some macro substitutions differently than on the
other platforms I had built and tested with.
The simple fix is to convert the new _attrs()* functions
in include/linux/dma-mapping.h into macros.
An updated patch follows. Built for alpha, ia64, x86_64.
Tested on ia64 and x86_64.
--
Arthur
prev parent reply other threads:[~2008-04-01 1:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-20 1:07 [PATCH 0/3 v5] dma: add dma_*map*_attrs() interfaces akepner
2008-03-28 3:18 ` Andrew Morton
2008-04-01 1:31 ` akepner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080401013159.GA29410@sgi.com \
--to=akepner@sgi.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=grundler@parisc-linux.org \
--cc=jbarnes@virtuousgeek.org \
--cc=jes@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael@ellerman.id.au \
--cc=randy.dunlap@oracle.com \
--cc=rdreier@cisco.com \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox