From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Greg KH <greg@kroah.com>
Cc: Kay Sievers <kay.sievers@vrfy.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Bj?rn Steinbrink <B.Steinbrink@gmx.de>,
Arjan van de Ven <arjan@linux.intel.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Johannes Berg <johannes@sipsolutions.net>,
Jiri Kosina <jkosina@suse.cz>
Subject: Re: [PATCH] evdev: Release eventual input device grabs when getting disconnected
Date: Mon, 31 Mar 2008 23:30:19 -0400 [thread overview]
Message-ID: <20080401033019.GA18041@anvil.corenet.prv> (raw)
In-Reply-To: <20080331220906.GA28171@kroah.com>
On Mon, Mar 31, 2008 at 03:09:06PM -0700, Greg KH wrote:
> On Mon, Mar 31, 2008 at 04:57:36PM -0400, Dmitry Torokhov wrote:
> >
> > Ok, I really liked the old behavior better, but if it is to stay then
> > we need something like this (not for inclusion yet as mousedev and joydev
> > need to be adjusted as well):
>
> Yes, that's the proper behavior anyway, as you are passing off a pointer
> to a device, you need to keep the reference to that device around until
> you are finished with it.
>
> I'm amazed that this wasn't causing a problem before the kobject change,
> as this should have been needed there as well. Would running with slab
> debugging cause it to hit then?
>
It worked because evdev (and mousedev, joydev) are direct children of
input_dev and prior to Kay change parent would stay till all childrens
are gone.
I will ask Linus to pull extended patch covering also joydev and mousedev
shortly.
--
Dmitry
next prev parent reply other threads:[~2008-04-01 3:30 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-30 18:42 [PATCH] evdev: Release eventual input device grabs when getting disconnected Björn Steinbrink
2008-03-30 21:51 ` Linus Torvalds
2008-03-30 22:22 ` Greg KH
2008-03-30 22:35 ` Linus Torvalds
2008-03-30 22:42 ` Björn Steinbrink
2008-03-30 23:19 ` Arjan van de Ven
2008-03-31 20:46 ` Dmitry Torokhov
2008-03-31 6:15 ` Dmitry Torokhov
2008-03-31 17:28 ` Greg KH
2008-03-31 18:01 ` Dmitry Torokhov
2008-03-31 18:24 ` Linus Torvalds
2008-03-31 23:12 ` Benjamin Herrenschmidt
2008-03-31 23:51 ` Greg KH
2008-04-01 1:01 ` Benjamin Herrenschmidt
2008-03-31 20:42 ` Greg KH
2008-03-31 20:57 ` Dmitry Torokhov
2008-03-31 22:09 ` Greg KH
2008-04-01 3:30 ` Dmitry Torokhov [this message]
2008-03-31 21:27 ` Jiri Kosina
2008-03-31 22:46 ` Kay Sievers
2008-03-31 20:21 ` Johannes Berg
2008-03-31 19:05 ` Björn Steinbrink
2008-04-01 11:51 ` Johannes Berg
2008-04-01 15:20 ` Björn Steinbrink
2008-04-02 9:17 ` Johannes Berg
2008-03-31 21:02 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080401033019.GA18041@anvil.corenet.prv \
--to=dmitry.torokhov@gmail.com \
--cc=B.Steinbrink@gmx.de \
--cc=arjan@linux.intel.com \
--cc=greg@kroah.com \
--cc=jkosina@suse.cz \
--cc=johannes@sipsolutions.net \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox