public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: "Sapan Bhatia" <sapan.bhatia@gmail.com>
Cc: linux-kernel@vger.kernel.org, daniel@hozac.com
Subject: Re: race leading to held mutexes, inode_cache corruption
Date: Tue, 1 Apr 2008 21:28:20 -0700	[thread overview]
Message-ID: <20080401212820.7e6c3519.akpm@linux-foundation.org> (raw)
In-Reply-To: <3cb76b010804012113p1758addsbfaea2882280b082@mail.gmail.com>

On Wed, 2 Apr 2008 00:13:04 -0400 "Sapan Bhatia" <sapan.bhatia@gmail.com> wrote:

> >
> >
> > That's the only way in which I can interpret your second paragraph, but as
> > far as I can tell the code cannot do that.
> >
> > Can you provide more detail?
> >
> 
> On running the example again, it seems that attributing the problem to a
> generic locking bug was a misdiagnosis. I apologize for the misinformation.
> The error is more likely a path with a dangling mutex_lock somewhere, or
> something else. I'll investigate further and try to provide a more detailed
> description of the problem when I have something concrete.
> 

OK, thanks.

Recent kernels have this:

config DEBUG_LOCK_ALLOC
	bool "Lock debugging: detect incorrect freeing of live locks"
	depends on DEBUG_KERNEL && TRACE_IRQFLAGS_SUPPORT && STACKTRACE_SUPPORT && LOCKDEP_SUPPORT
	select DEBUG_SPINLOCK
	select DEBUG_MUTEXES
	select LOCKDEP
	help
	 This feature will check whether any held lock (spinlock, rwlock,
	 mutex or rwsem) is incorrectly freed by the kernel, via any of the
	 memory-freeing routines (kfree(), kmem_cache_free(), free_pages(),
	 vfree(), etc.), whether a live lock is incorrectly reinitialized via
	 spin_lock_init()/mutex_init()/etc., or whether there is any lock
	 held during task exit.

which seems rather relevant, no? ;)

      parent reply	other threads:[~2008-04-02  4:28 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-02  1:15 race leading to held mutexes, inode_cache corruption Sapan Bhatia
2008-04-02  1:38 ` Andrew Morton
     [not found]   ` <3cb76b010804012113p1758addsbfaea2882280b082@mail.gmail.com>
2008-04-02  4:28     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080401212820.7e6c3519.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=daniel@hozac.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sapan.bhatia@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox