From: Al Viro <viro@ZenIV.linux.org.uk>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Harvey Harrison <harvey.harrison@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
LKML <linux-kernel@vger.kernel.org>,
josh@freedesktop.org
Subject: Re: [PATCH 7/7] asm-generic: suppress sparse warning in ioctl.h
Date: Thu, 3 Apr 2008 03:55:46 +0100 [thread overview]
Message-ID: <20080403025546.GB9785@ZenIV.linux.org.uk> (raw)
In-Reply-To: <alpine.LFD.1.00.0804021950260.14670@woody.linux-foundation.org>
On Wed, Apr 02, 2008 at 07:51:08PM -0700, Linus Torvalds wrote:
>
>
> On Thu, 3 Apr 2008, Al Viro wrote:
> >
> > Um... But that's _not_ a link-time constant - simply an int variable not
> > defined in any object file...
>
> Ahh, you're right, my bad. We could change it to take the address of it,
> though. I assume gcc is happy with that too?
gcc might be, but what are you going to do with it? Expression is an
integer one, after all - in cases that had triggered that thread it
was used (after & 0xff) as array index.
Besides, logically it's _not_ a constant at all - not even a base + constant,
after using it in such expression...
next prev parent reply other threads:[~2008-04-03 2:55 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 0:33 [PATCH 7/7] asm-generic: suppress sparse warning in ioctl.h Harvey Harrison
2008-04-03 0:57 ` Linus Torvalds
2008-04-03 1:34 ` Al Viro
2008-04-03 1:50 ` Linus Torvalds
2008-04-03 1:59 ` Al Viro
2008-04-03 2:51 ` Linus Torvalds
2008-04-03 2:55 ` Al Viro [this message]
2008-04-04 9:19 ` Al Viro
2008-04-03 2:41 ` Al Viro
2008-04-03 20:31 ` Josh Triplett
2008-04-04 1:19 ` Al Viro
2008-04-04 2:00 ` Al Viro
2008-04-04 14:08 ` Derek M Jones
2008-04-04 18:42 ` Al Viro
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080403025546.GB9785@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=josh@freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).