From: Jens Axboe <jens.axboe@oracle.com>
To: Hugh Dickins <hugh@veritas.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] splice: use mapping_gfp_mask
Date: Fri, 4 Apr 2008 13:46:09 +0200 [thread overview]
Message-ID: <20080404114609.GG29686@kernel.dk> (raw)
In-Reply-To: <Pine.LNX.4.64.0804032331190.27180@blonde.site>
On Thu, Apr 03 2008, Hugh Dickins wrote:
> The loop block driver is careful to mask __GFP_IO|__GFP_FS out of its
> mapping_gfp_mask, to avoid hangs under memory pressure. But nowadays
> it uses splice, usually going through __generic_file_splice_read. That
> must use mapping_gfp_mask instead of GFP_KERNEL to avoid those hangs.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
> Ought to go into 2.6.25. For 2.6.23 and 2.6.24 stable? Well, I've
> not actually seen this hang on any of these, though presumably it's
> lurking there. Where I did see it, and test the fix, was 2.6.25-rc5-mm1:
> whose SLUB had a disturbing predilection (since corrected) for order-4
> allocations, even when allocating radix tree nodes.
Thanks Hugh, definitely correct! I see it's already merged, so all is
well.
--
Jens Axboe
next prev parent reply other threads:[~2008-04-04 11:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 22:35 [PATCH] splice: use mapping_gfp_mask Hugh Dickins
2008-04-04 11:46 ` Jens Axboe [this message]
2008-04-04 20:54 ` Oliver Pinter
2008-04-05 7:23 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080404114609.GG29686@kernel.dk \
--to=jens.axboe@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=hugh@veritas.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).