From: Rusty Russell <rusty@rustcorp.com.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Andi Kleen <ak@suse.de>, "H. Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
lguest <lguest@ozlabs.org>
Subject: [PATCH] Fix booting pentium+ with dodgy TSC
Date: Sun, 6 Apr 2008 17:23:38 +1000 [thread overview]
Message-ID: <200804061723.38766.rusty@rustcorp.com.au> (raw)
Linus please apply. Almost by definition this patch can't make things worse.
We handle a broken tsc these days, so no need to panic. We clear the TSC bit
when tsc_init decides it's unreliable (eg. under lguest w/ bad host TSC),
leading to bogus panic.
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
diff -r 5e0a39f4d07b arch/x86/kernel/cpu/bugs.c
--- a/arch/x86/kernel/cpu/bugs.c Sun Apr 06 13:40:39 2008 +1000
+++ b/arch/x86/kernel/cpu/bugs.c Sun Apr 06 17:14:12 2008 +1000
@@ -143,14 +143,6 @@ static void __init check_config(void)
#endif
/*
- * If we configured ourselves for a TSC, we'd better have one!
- */
-#ifdef CONFIG_X86_TSC
- if (!cpu_has_tsc)
- panic("Kernel compiled for Pentium+, requires TSC feature!");
-#endif
-
-/*
* If we were told we had a good local APIC, check for buggy Pentia,
* i.e. all B steppings and the C2 stepping of P54C when using their
* integrated APIC (see 11AP erratum in "Pentium Processor
next reply other threads:[~2008-04-06 7:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-06 7:23 Rusty Russell [this message]
2008-04-06 11:22 ` [PATCH] Fix booting pentium+ with dodgy TSC Ingo Molnar
2008-04-06 20:29 ` Rusty Russell
2008-04-11 15:43 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804061723.38766.rusty@rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=ak@suse.de \
--cc=hpa@zytor.com \
--cc=lguest@ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox