From: Andrew Morton <akpm@linux-foundation.org>
To: Dmitry Baryshkov <dbaryshkov@gmail.com>
Cc: linux-kernel@vger.kernel.org, haavard.skinnemoen@atmel.com,
rmk+lkml@arm.linux.org.uk, lethal@linux-sh.org,
philipp.zabel@gmail.com, pavel@ucw.cz, tony@atomide.com,
paul@pwsan.com
Subject: Re: [PATCH 6/6] Clocklib: use correct name for 3,6MHz clock
Date: Mon, 7 Apr 2008 16:01:55 -0700 [thread overview]
Message-ID: <20080407160155.5e6d77f0.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080403132411.GA27017@doriath.ww600.siemens.net>
On Thu, 3 Apr 2008 17:24:11 +0400
Dmitry Baryshkov <dbaryshkov@gmail.com> wrote:
> Signed-off-by: Dmitry Baryshkov <dbaryshkov@gmail.com>
> ---
> arch/arm/common/sa1111.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/arm/common/sa1111.c b/arch/arm/common/sa1111.c
> index eb06d0b..282a4d9 100644
> --- a/arch/arm/common/sa1111.c
> +++ b/arch/arm/common/sa1111.c
> @@ -627,7 +627,7 @@ __sa1111_probe(struct device *me, struct resource *mem, int irq)
> if (!sachip)
> return -ENOMEM;
>
> - sachip->clk = clk_get(me, "GPIO27_CLK");
> + sachip->clk = clk_get(me, "3_6MHz_CLK");
> if (!sachip->clk) {
> ret = PTR_ERR(sachip->clk);
> goto err_free;
Again, there's just not enough information for us (well: me) to be able to
evaluate this patch.
For example, if the current name is "incorrect" then why shouldn't we fix
it in 2.6.25? 2.6.24? etc.
next prev parent reply other threads:[~2008-04-07 23:03 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 13:21 [PATCH 0/6] Clocklib: generic clocks framework Dmitry Baryshkov
2008-04-03 13:23 ` [PATCH 1/6] Clocklib: add generic framework for managing clocks Dmitry Baryshkov
2008-04-07 22:55 ` Andrew Morton
2008-04-03 13:23 ` [PATCH 2/6] Clocklib: debugfs support Dmitry Baryshkov
2008-04-07 22:59 ` Andrew Morton
2008-04-08 1:04 ` Greg KH
2008-04-03 13:23 ` [PATCH 3/6] Clocklib: support sa1100 sub-arch Dmitry Baryshkov
2008-04-03 13:23 ` [PATCH 4/6] Clocklib: support ARM pxa sub-arch Dmitry Baryshkov
2008-04-03 13:24 ` [PATCH 5/6] Clocklib: Use correct clock for IrDA on pxa Dmitry Baryshkov
2008-04-07 23:00 ` Andrew Morton
2008-04-07 23:04 ` Russell King
2008-04-08 9:47 ` Dmitry
2008-04-08 19:33 ` Russell King
2008-04-09 7:15 ` Dmitry
2008-04-09 19:05 ` Russell King
2008-04-09 19:09 ` Alan Cox
2008-04-09 19:20 ` Russell King
2008-04-09 19:39 ` Dmitry
2008-04-09 20:52 ` Alan Cox
2008-04-09 21:37 ` Russell King
2008-04-03 13:24 ` [PATCH 6/6] Clocklib: use correct name for 3,6MHz clock Dmitry Baryshkov
2008-04-07 23:01 ` Andrew Morton [this message]
2008-04-07 23:06 ` Russell King
2008-04-08 9:52 ` Dmitry
2008-04-08 19:35 ` Russell King
2008-04-08 19:58 ` Dmitry
2008-04-08 20:07 ` Russell King
2008-04-09 7:19 ` Dmitry
2008-04-11 10:25 ` Dmitry Baryshkov
-- strict thread matches above, loose matches on Subject: below --
2008-03-31 8:39 [PATCH 0/6] Clocklib: generic clocks framework Dmitry Baryshkov
2008-03-31 8:45 ` [PATCH 6/6] Clocklib: use correct name for 3,6MHz clock Dmitry Baryshkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080407160155.5e6d77f0.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=dbaryshkov@gmail.com \
--cc=haavard.skinnemoen@atmel.com \
--cc=lethal@linux-sh.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paul@pwsan.com \
--cc=pavel@ucw.cz \
--cc=philipp.zabel@gmail.com \
--cc=rmk+lkml@arm.linux.org.uk \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox