From: Jarod Wilson <jwilson@redhat.com>
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org,
"Kristian Høgsberg" <krh@redhat.com>
Subject: Re: [PATCH] firewire: fw-ohci: conditionally log busReset interrupts
Date: Mon, 7 Apr 2008 17:28:14 -0400 [thread overview]
Message-ID: <200804071728.14564.jwilson@redhat.com> (raw)
In-Reply-To: <tkrat.f295cee296185297@s5r6.in-berlin.de>
On Monday 07 April 2008 04:33:35 pm Stefan Richter wrote:
> Add a debug option to watch bus reset interrupt events. Half of this
> patch is taken from Jarod Wilson's first version of the JMicron fix.
>
> BusReset interrupts are only generated if the respective module
> parameter flag was set before the controller is being initialized. We
> keep this event masked otherwise to reduce IRQ load in normal operation
> and to avoid potential problems with buggy chips.
>
> Note, this is unlike the other IRQ events whose logging can be enabled
> any time after chip initialization. This and the influence on what
> interrupts the chip generates is why I added an extra flag for it.
>
> Also, reorder the debug parameter flags according to their perceived
> usefulness.
>
> Signed-off-by: Stefan Richter <stefanr@s5r6.in-berlin.de>
> ---
Indeed, after discussing, this looks much safer.
Signed-off-by: Jarod Wilson <jwilson@redhat.com>
--
Jarod Wilson
jwilson@redhat.com
prev parent reply other threads:[~2008-04-07 21:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200804041705.16864.jwilson@redhat.com>
[not found] ` <200804071228.15292.jwilson@redhat.com>
[not found] ` <tkrat.18969adb4d4aaefb@s5r6.in-berlin.de>
[not found] ` <200804071254.00197.jwilson@redhat.com>
2008-04-07 20:32 ` [PATCH update 2] firewire: fw-ohci: don't append to AT context when its not active Stefan Richter
2008-04-07 20:33 ` [PATCH] firewire: fw-ohci: conditionally log busReset interrupts Stefan Richter
2008-04-07 21:28 ` Jarod Wilson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200804071728.14564.jwilson@redhat.com \
--to=jwilson@redhat.com \
--cc=krh@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
--cc=stefanr@s5r6.in-berlin.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox