* Re: Fix "buggy BIOS check" when CPUs are hot removed
2008-04-04 23:48 Fix "buggy BIOS check" when CPUs are hot removed Alok Kataria
@ 2008-04-07 18:55 ` Alok Kataria
2008-04-08 7:03 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Alok Kataria @ 2008-04-07 18:55 UTC (permalink / raw)
To: len.brown
Cc: rui.zhang, linux-acpi, linux-kernel, Daniel Arai, Zachary Amsden
[-- Attachment #1: Type: text/plain, Size: 1810 bytes --]
This patch too seems malformed. Resending and also find attached.
Thanks,
Alok
--
Fix "buggy BIOS check" when CPUs are hot added and removed
processor_device_array[pr->id] needs to be set to NULL when removing a
CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
fires when a CPU is removed from the system and then later re-added.
Signed-off-by: Alok N Kataria <akataria@vmware.com>
Signed-off-by: Dan Arai <arai@vmware.com>
---
drivers/acpi/processor_core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/processor_core.c
b/drivers/acpi/processor_core.c
index 61450f4..0f95f26 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
*device, int type)
}
processors[pr->id] = NULL;
+ processor_device_array[pr->id] = NULL;
kfree(pr);
--
1.5.4
On Fri, 2008-04-04 at 16:48 -0700, Alok Kataria wrote:
> Fixes a BUG in ACPI hotplugging.
>
> processor_device_array[pr->id] needs to be set to NULL when removing a
> CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
> fires when a CPU is removed from the system and then later re-added.
>
> Signed-off-by: Alok N Kataria <akataria@vmware.com>
> Signed-off-by: Dan Arai <arai@vmware.com>
>
> ---
> drivers/acpi/processor_core.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/acpi/processor_core.c
> b/drivers/acpi/processor_core.c
> index 61450f4..0f95f26 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
> *device, int type)
> }
>
> processors[pr->id] = NULL;
> + processor_device_array[pr->id] = NULL;
>
> kfree(pr);
>
[-- Attachment #2: buggy-bios-check-on-cpu-hotplug.patch --]
[-- Type: text/x-patch, Size: 859 bytes --]
Fix "buggy BIOS check" when CPUs are hot added and removed
processor_device_array[pr->id] needs to be set to NULL when removing a
CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
fires when a CPU is removed from the system and then later re-added.
Signed-off-by: Alok N Kataria <akataria@vmware.com>
Signed-off-by: Dan Arai <arai@vmware.com>
---
drivers/acpi/processor_core.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/drivers/acpi/processor_core.c b/drivers/acpi/processor_core.c
index 61450f4..0f95f26 100644
--- a/drivers/acpi/processor_core.c
+++ b/drivers/acpi/processor_core.c
@@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device *device, int type)
}
processors[pr->id] = NULL;
+ processor_device_array[pr->id] = NULL;
kfree(pr);
--
1.5.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: Fix "buggy BIOS check" when CPUs are hot removed
2008-04-04 23:48 Fix "buggy BIOS check" when CPUs are hot removed Alok Kataria
2008-04-07 18:55 ` Alok Kataria
@ 2008-04-08 7:03 ` Andrew Morton
1 sibling, 0 replies; 3+ messages in thread
From: Andrew Morton @ 2008-04-08 7:03 UTC (permalink / raw)
To: Alok Kataria
Cc: len.brown, rui.zhang, linux-acpi, linux-kernel, Daniel Arai,
Zachary Amsden, stable
On Fri, 04 Apr 2008 16:48:44 -0700 Alok Kataria <akataria@vmware.com> wrote:
> Fixes a BUG in ACPI hotplugging.
>
> processor_device_array[pr->id] needs to be set to NULL when removing a
> CPU. Else the "buggy BIOS check" in acpi_processor_start mistakenly
> fires when a CPU is removed from the system and then later re-added.
>
> Signed-off-by: Alok N Kataria <akataria@vmware.com>
> Signed-off-by: Dan Arai <arai@vmware.com>
I assume this is also needed in 2.6.24.x?
> diff --git a/drivers/acpi/processor_core.c
> b/drivers/acpi/processor_core.c
> index 61450f4..0f95f26 100644
> --- a/drivers/acpi/processor_core.c
> +++ b/drivers/acpi/processor_core.c
> @@ -828,6 +828,7 @@ static int acpi_processor_remove(struct acpi_device
> *device, int type)
> }
>
> processors[pr->id] = NULL;
> + processor_device_array[pr->id] = NULL;
>
> kfree(pr);
>
That set a new record for patch-manglement.
^ permalink raw reply [flat|nested] 3+ messages in thread