From: Christoph Hellwig <hch@infradead.org>
To: Steven Whitehouse <swhiteho@redhat.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Christoph Hellwig <hch@infradead.org>, Neil Brown <neilb@suse.de>,
"J. Bruce Fields" <bfields@fieldses.org>,
Adrian Bunk <bunk@kernel.org>
Subject: Re: [NFS] Increase size of struct fid raw buffer
Date: Tue, 8 Apr 2008 03:58:07 -0400 [thread overview]
Message-ID: <20080408075807.GA8893@infradead.org> (raw)
In-Reply-To: <1207641005.3635.238.camel@quoit>
On Tue, Apr 08, 2008 at 08:50:05AM +0100, Steven Whitehouse wrote:
> I'm happy with that solution, although I'd assumed that the reason this
> field had a size in the first place was that the NFS people had a plan
> to use the structure as an allocation entity in the future. Can an NFS
> developer please confirm/deny this?
>
> If everybody is happy with the plan, then I'll send a patch to make the
> change as you suggest shortly,
I've introduce it and I don't plan to use it as allocation entity. I
don't quite remember why I sized it either, so it's conceptually fine
to make it a VLA. Just do some testing with that variant please.
next prev parent reply other threads:[~2008-04-08 7:58 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 9:47 [NFS] Increase size of struct fid raw buffer Steven Whitehouse
2008-04-07 15:54 ` Linus Torvalds
2008-04-08 7:50 ` Steven Whitehouse
2008-04-08 7:58 ` Christoph Hellwig [this message]
2008-04-08 9:57 ` Steven Whitehouse
2008-04-08 13:01 ` [NFS] Use a zero sized array for raw field in struct fid Steven Whitehouse
2008-04-09 16:13 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080408075807.GA8893@infradead.org \
--to=hch@infradead.org \
--cc=bfields@fieldses.org \
--cc=bunk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=neilb@suse.de \
--cc=swhiteho@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox