From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753740AbYDHH6U (ORCPT ); Tue, 8 Apr 2008 03:58:20 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751791AbYDHH6N (ORCPT ); Tue, 8 Apr 2008 03:58:13 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:47135 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751781AbYDHH6M (ORCPT ); Tue, 8 Apr 2008 03:58:12 -0400 Date: Tue, 8 Apr 2008 03:58:07 -0400 From: Christoph Hellwig To: Steven Whitehouse Cc: Linus Torvalds , linux-kernel@vger.kernel.org, Christoph Hellwig , Neil Brown , "J. Bruce Fields" , Adrian Bunk Subject: Re: [NFS] Increase size of struct fid raw buffer Message-ID: <20080408075807.GA8893@infradead.org> References: <1207561677.3635.166.camel@quoit> <1207641005.3635.238.camel@quoit> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1207641005.3635.238.camel@quoit> User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 08, 2008 at 08:50:05AM +0100, Steven Whitehouse wrote: > I'm happy with that solution, although I'd assumed that the reason this > field had a size in the first place was that the NFS people had a plan > to use the structure as an allocation entity in the future. Can an NFS > developer please confirm/deny this? > > If everybody is happy with the plan, then I'll send a patch to make the > change as you suggest shortly, I've introduce it and I don't plan to use it as allocation entity. I don't quite remember why I sized it either, so it's conceptually fine to make it a VLA. Just do some testing with that variant please.