public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	linux-kbuild@vger.kernel.org, samr <sam@ravnborg.org>
Subject: Re: [PATCH] documentation: build source files in Documentation sub-dir
Date: Tue, 8 Apr 2008 13:46:13 -0700	[thread overview]
Message-ID: <20080408134613.a047a7b6.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080403124529.3f2efb79.randy.dunlap@oracle.com>

On Thu, 3 Apr 2008 12:45:29 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:

> Currently source files in the Documentation/ sub-dir can easily bit-rot
> since they are not generally buildable, either because they are hidden
> in text files or because there are no Makefile rules for them.
> This needs to be fixed so that the source files remain usable and good
> examples of code instead of bad examples.
> 
> Add the ability to build source files that are in the Documentation/ dir.
> Add to Kconfig as "BUILD_DOCSRC" config symbol.
> 
> Use "CONFIG_BUILD_DOCSRC=1 make ..." to build objects from the
> Documentation/ sources.  Or enable BUILD_DOCSRC in the *config system.
> 
> The Makefiles use $objdir/usr/include for header files, so doing
> "make headers_install" is required.  This is done for you if you enable
> CONFIG_HEADERS_CHECK=y.
> 
> Note: needs documentation-move-spidev_fdx-example-to-its-own-source-file.patch
> from -mm patchset.

argh, I'm getting several warnings and at least two build errors from this.
One is:

In file included from /usr/src/devel/usr/include/linux/netlink.h:5,
                 from /usr/src/devel/usr/include/linux/genetlink.h:4,
                 from Documentation/accounting/getdelays.c:26:
/usr/src/devel/usr/include/linux/types.h:166: error: expected specifier-qualifier-list before '__kernel_daddr_t'

(i386 allmodconfig).

I think I'll disable this patch for now..

  reply	other threads:[~2008-04-08 20:48 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-03 19:45 [PATCH] documentation: build source files in Documentation sub-dir Randy Dunlap
2008-04-08 20:46 ` Andrew Morton [this message]
2008-04-09 19:35   ` [PATCH v2] " Randy Dunlap
2008-04-09 21:54     ` Andrew Morton
2008-04-11  0:56       ` Randy Dunlap
2008-04-11  1:11         ` Andrew Morton
2008-04-13 14:05           ` Thomas Gleixner
2008-04-09 22:52     ` Nick Andrew
2008-04-09 23:53       ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080408134613.a047a7b6.akpm@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=randy.dunlap@oracle.com \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox