From: Cyrill Gorcunov <gorcunov@gmail.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>,
LKML <linux-kernel@vger.kernel.org>,
Yinghai Lu <yhlu.kernel@gmail.com>
Subject: Re: bootmem allocator
Date: Tue, 8 Apr 2008 21:34:18 +0400 [thread overview]
Message-ID: <20080408173418.GD7656@cvg> (raw)
In-Reply-To: <20080408081206.GL16647@one.firstfloor.org>
[Andi Kleen - Tue, Apr 08, 2008 at 10:12:06AM +0200]
| On Tue, Apr 08, 2008 at 10:04:46AM +0200, Ingo Molnar wrote:
| >
| > * Andi Kleen <andi@firstfloor.org> wrote:
| >
| > > > hm, bootmem allocator is supposed to clear memory. We have a couple
| > > > of places that rely on that.
| > >
| > > I was actually considering to change that for the GB pages hugetlbfs
| > > patchkit, because memset for 1G is a little slow and not needed (will
| > > be cleared later anyways) and it might be a problem for very large
| > > systems with a lot of such pages at boot.
| >
| > changing the default behavior of bootmem alloc to be non-clearing is a
| > really bad idea that will only cause unrobustness. The proper approach
| > is to add an _opt-in_ API that does not clear memory
|
| I was considering that too, but we have so many weird variants of bootmem
| with opt in and opt out and even combinations of both now that the whole thing
| is starting to look really pear shaped (I admit I added some of them
| in the past myself but I'm not proud). Would be a great project for
| someone to consolidate that all a bit.
|
| -Andi
|
Andi, could you a bit clarify what exactly do you mean?
- Cyrill -
next prev parent reply other threads:[~2008-04-08 17:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-07 18:56 bootmem allocator Cyrill Gorcunov
2008-04-07 19:09 ` Ingo Molnar
2008-04-07 19:44 ` Andi Kleen
2008-04-07 21:45 ` Yinghai Lu
2008-04-08 4:14 ` Cyrill Gorcunov
2008-04-08 4:33 ` H. Peter Anvin
2008-04-08 5:50 ` Cyrill Gorcunov
2008-04-08 16:18 ` Cyrill Gorcunov
2008-04-08 8:04 ` Ingo Molnar
2008-04-08 8:12 ` Andi Kleen
2008-04-08 13:57 ` Cyrill Gorcunov
2008-04-08 17:34 ` Cyrill Gorcunov [this message]
2008-04-08 17:44 ` H. Peter Anvin
2008-04-09 6:00 ` Mike Travis
2008-04-09 6:08 ` Andi Kleen
2008-04-09 6:55 ` Mike Travis
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080408173418.GD7656@cvg \
--to=gorcunov@gmail.com \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox