From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755802AbYDHVa5 (ORCPT ); Tue, 8 Apr 2008 17:30:57 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754162AbYDHVan (ORCPT ); Tue, 8 Apr 2008 17:30:43 -0400 Received: from relay1.sgi.com ([192.48.171.29]:53697 "EHLO relay.sgi.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754108AbYDHVam (ORCPT ); Tue, 8 Apr 2008 17:30:42 -0400 From: akepner@sgi.com Date: Tue, 8 Apr 2008 14:29:12 -0700 To: Roland Dreier Cc: Andrew Morton , Tony Luck , Jesse Barnes , Jes Sorensen , Randy Dunlap , James Bottomley , David Miller , Benjamin Herrenschmidt , Grant Grundler , Michael Ellerman , linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3 v6] IB: expand ib_umem_get() prototype Message-ID: <20080408212912.GI29410@sgi.com> References: <20080401013744.GE29410@sgi.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Apr 08, 2008 at 12:40:21PM -0700, Roland Dreier wrote: > All of this looks good to me, and I'm happy we are finally fixing this > up. However, now that it is finally ready to merge, I started thinking > about the libmthca changes required to handle this, and I realized that > we can actually avoid this: > ..... > with my proposed change, the only difference is: > > new kernel, old userspace: current behavior (subtle failure on Altix), > plus print a warning telling people to > update userspace. > .... > > Andrew: if Arthur agrees with this, please roll the patch below into the > current IB patch you have as part of the dma attrs series. Sounds fine to me, Roland. Acked-by: Arthur Kepner -- Arthur