From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756454AbYDIVz4 (ORCPT ); Wed, 9 Apr 2008 17:55:56 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753460AbYDIVzZ (ORCPT ); Wed, 9 Apr 2008 17:55:25 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:33590 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753135AbYDIVzX (ORCPT ); Wed, 9 Apr 2008 17:55:23 -0400 Date: Wed, 9 Apr 2008 14:54:09 -0700 From: Andrew Morton To: Randy Dunlap Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org, sam@ravnborg.org, Ingo Molnar , Thomas Gleixner Subject: Re: [PATCH v2] documentation: build source files in Documentation sub-dir Message-Id: <20080409145409.615cd236.akpm@linux-foundation.org> In-Reply-To: <20080409123551.42c5da0d.randy.dunlap@oracle.com> References: <20080403124529.3f2efb79.randy.dunlap@oracle.com> <20080408134613.a047a7b6.akpm@linux-foundation.org> <20080409123551.42c5da0d.randy.dunlap@oracle.com> X-Mailer: Sylpheed version 2.2.4 (GTK+ 2.8.20; i486-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 9 Apr 2008 12:35:51 -0700 Randy Dunlap wrote: > On Tue, 8 Apr 2008 13:46:13 -0700 Andrew Morton wrote: > > > On Thu, 3 Apr 2008 12:45:29 -0700 Randy Dunlap wrote: > > > > > Currently source files in the Documentation/ sub-dir can easily bit-rot > > > since they are not generally buildable, either because they are hidden > > > in text files or because there are no Makefile rules for them. > > > This needs to be fixed so that the source files remain usable and good > > > examples of code instead of bad examples. > > > > > > Add the ability to build source files that are in the Documentation/ dir. > > > Add to Kconfig as "BUILD_DOCSRC" config symbol. > > > > > > Use "CONFIG_BUILD_DOCSRC=1 make ..." to build objects from the > > > Documentation/ sources. Or enable BUILD_DOCSRC in the *config system. > > > > > > The Makefiles use $objdir/usr/include for header files, so doing > > > "make headers_install" is required. This is done for you if you enable > > > CONFIG_HEADERS_CHECK=y. > > > > > > Note: needs documentation-move-spidev_fdx-example-to-its-own-source-file.patch > > > from -mm patchset. > > > > argh, I'm getting several warnings and at least two build errors from this. > > One is: > > > > In file included from /usr/src/devel/usr/include/linux/netlink.h:5, > > from /usr/src/devel/usr/include/linux/genetlink.h:4, > > from Documentation/accounting/getdelays.c:26: > > /usr/src/devel/usr/include/linux/types.h:166: error: expected specifier-qualifier-list before '__kernel_daddr_t' > > > > (i386 allmodconfig). > > > > I think I'll disable this patch for now.. > > Oh drat and curses. > > Change all -I$(srctree) in Makefiles to -I$(objtree). > New (full) patch file with only that change is below. > I can send a patch with only those changes if you prefer that. > > Cross-build using O= works now. I wasn't using O=. It turns out that this is breakage introduced by git-x86.patch. Reproducible via: setenv ARCH i386 make mrproper make allmodconfig gcc -I$(/bin/pwd)/include Documentation/accounting/getdelays.c -o getdelays In file included from /usr/src/devel/include/linux/netlink.h:5, from /usr/src/devel/include/linux/genetlink.h:4, from Documentation/accounting/getdelays.c:26: /usr/src/devel/include/linux/types.h:203: error: expected specifier-qualifier-list before '__kernel_daddr_t'