From: Mauro Carvalho Chehab <mchehab@infradead.org>
To: Harvey Harrison <harvey.harrison@gmail.com>
Cc: Michael Krufky <mkrufky@linuxtv.org>,
akpm@linux-foundation.org, v4l-dvb-maintainer@linuxtv.org,
linux-kernel@vger.kernel.org, abraham.manu@gmail.com
Subject: Re: [v4l-dvb-maintainer] [PATCH] media: replace remaining __FUNCT ION__ occurences
Date: Wed, 9 Apr 2008 15:58:00 -0300 [thread overview]
Message-ID: <20080409155800.3c321b76@areia> (raw)
In-Reply-To: <1207765825.16220.16.camel@brick>
On Wed, 09 Apr 2008 11:30:25 -0700
Harvey Harrison <harvey.harrison@gmail.com> wrote:
> For such a large set in v4l, it's a drastic increase in work to do so
> in this case as it is a simple sed s/__FUNCTION__/__func__/
I think the "sed" approach is the better, on this case. It avoids mistakes that
might be caused by manual changes of that amount of line changes.
> > I understand if you don't want to alter code that you may not be
> > directly involved in, but I am sure you will have no trouble at least
> > fixing the "comma after space" and "line over 80 characters" cases.
> >
> > Please generate the additional cleanups against the mercurial tree
> > that I merged your previous series to:
> >
> > http://linuxtv.org/hg/~mkrufky/function-func
>
> Do you have a git mirror somewhere?
The V4L/DVB -git tree is at:
http://www.kernel.org/git/?p=linux/kernel/git/mchehab/v4l-dvb.git
Also, linux-next is updated with the same patches applied on the above tree.
However, some manual adjustments may still be needed, since we have backward
compatibility code on Mercurial (to allow users to test V4L/DVB drivers on
older kernels).
At the -git, all those #if KERNEL_VERSION stuff that are inside Mercurial are
stripped.
Cheers,
Mauro
next prev parent reply other threads:[~2008-04-09 19:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-03-04 0:03 [PATCH] media: replace remaining __FUNCTION__ occurences Harvey Harrison
2008-03-04 3:28 ` [v4l-dvb-maintainer] " Michael Krufky
2008-03-04 3:29 ` Harvey Harrison
2008-03-04 3:47 ` Michael Krufky
2008-03-04 5:17 ` Manu Abraham
2008-03-04 6:38 ` Michael Krufky
2008-03-04 6:54 ` Harvey Harrison
2008-04-03 19:58 ` [v4l-dvb-maintainer] [PATCH] media: replace remaining __FUNCT ION__ occurences mkrufky
2008-04-04 15:09 ` Michael Krufky
2008-04-09 17:00 ` Michael Krufky
2008-04-09 18:11 ` Oliver Endriss
2008-04-09 18:30 ` Harvey Harrison
2008-04-09 18:58 ` Mauro Carvalho Chehab [this message]
2008-04-09 19:05 ` mkrufky
2008-03-04 10:33 ` [v4l-dvb-maintainer] [PATCH] media: replace remaining __FUNCTION__ occurences Manu Abraham
2008-03-04 13:50 ` Mauro Carvalho Chehab
2008-03-04 20:19 ` Manu Abraham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080409155800.3c321b76@areia \
--to=mchehab@infradead.org \
--cc=abraham.manu@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=harvey.harrison@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mkrufky@linuxtv.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox