Re: [PATCH 6/6] Clocklib: use correct name for 3,6MHz clock

Dmitry
2008-04-09T07:19:49Z

Hi,

2008/4/9, Russell King <rmk+lkml@arm.linux.org.uk>:
> On Tue, Apr 08, 2008 at 11:58:11PM +0400, Dmitry wrote:
> > 2008/4/8, Russell King <rmk+lkml@arm.linux.org.uk>:
>
> > > So... what is the correct name. Bear in mind what I said in the previous
> > > reply this evening - which says that it should be the name used by the
> > > SA1111. Look in the data sheet - the pin itself to which the 3.6MHz
> > > clock is supplised will have a name. That's the name which should be
> > > used.
> >
> > I use the same pin/clock for the tc6393xb driver. And I'm pretty sure
> > the datasheets won't agree on the name of the pin. Which name should I
> > use?
>
>
> You missed the fundamental issue about the clock API - the _name_ is
> not the clock name defined by the host. It's the _device_ clock name.
>
> So, you shouldn't be using the SA1111 clock name for the tc6393xb driver.
> You should be using its own name. The platform specific bit of the clock
> API is then supposed to return you the struct clk corresponding with
> that input, by using the platform knowledge that it's connected to GPIO27
> or whatever.

I think I understood your idea. I'll repost updated patchset later.