From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Andres Salomon <dilinger@queued.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, info-linux@geode.amd.com,
jordan.crouse@amd.com
Subject: Re: [PATCH 2/3] x86: GEODE: add Virtual Systems Architecture detection
Date: Thu, 10 Apr 2008 09:10:57 +0100 [thread overview]
Message-ID: <20080410091057.45cbb938@core> (raw)
In-Reply-To: <20080409223328.5774d6cf@ephemeral>
On Wed, 9 Apr 2008 22:33:28 -0400
Andres Salomon <dilinger@queued.net> wrote:
>
> This is generic VSA detection. It's used by OLPC to determine whether or
> not the BIOS contains VSA, but since other BIOSes are coming out that don't
> use the VSA (ie, tinybios), it might end up being useful for others.
NAK - but minor
This is a check for *VSA2* which is not the same as VSA1 (Cyrix one) and
for older systems that actually matters as you may have VSA1 or VSA2 and
they are detected differently.
> +/* VSA magic values */
These should be VSA2 I think
> +static inline int geode_has_vsa(void)
has_vsa2
Alan (Keeper of the ancient cyrix docs ;))
next prev parent reply other threads:[~2008-04-10 8:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 2:33 [PATCH 2/3] x86: GEODE: add Virtual Systems Architecture detection Andres Salomon
2008-04-10 8:10 ` Alan Cox [this message]
2008-04-10 13:40 ` Andres Salomon
2008-04-10 14:20 ` Alan Cox
2008-04-11 1:53 ` Andres Salomon
2008-04-10 14:42 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080410091057.45cbb938@core \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@linux-foundation.org \
--cc=dilinger@queued.net \
--cc=info-linux@geode.amd.com \
--cc=jordan.crouse@amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox