From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755524AbYDJDeG (ORCPT ); Wed, 9 Apr 2008 23:34:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752406AbYDJDdz (ORCPT ); Wed, 9 Apr 2008 23:33:55 -0400 Received: from ozlabs.org ([203.10.76.45]:44586 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752076AbYDJDdz (ORCPT ); Wed, 9 Apr 2008 23:33:55 -0400 From: Rusty Russell To: Mathieu Desnoyers Subject: Re: [patch 16/17] Immediate Values - Documentation Date: Thu, 10 Apr 2008 13:33:35 +1000 User-Agent: KMail/1.9.9 Cc: akpm@linux-foundation.org, Ingo Molnar , linux-kernel@vger.kernel.org, Andi Kleen , Adrian Bunk , Alexey Dobriyan , Christoph Hellwig , akpm@osdl.org References: <20080409150829.855195878@polymtl.ca> <20080409152052.245356400@polymtl.ca> In-Reply-To: <20080409152052.245356400@polymtl.ca> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804101333.36419.rusty@rustcorp.com.au> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 10 April 2008 01:08:45 Mathieu Desnoyers wrote: > If you have to read the immediate values from a function declared as > __init or __exit, you should explicitly use _imv_read(), which will fall > back on a global variable read. Failing to do so will leave a reference to > the __init section after it is freed (it would generate a modpost > warning). That's a real usability wart. Couldn't we skip these in the patching loop if required and revert so noone can make this mistake? Thanks, Rusty.