From: Jordan Crouse <jordan.crouse@amd.com>
To: Andres Salomon <dilinger@queued.net>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, info-linux@geode.amd.com
Subject: Re: x86: GEODE: add Virtual Systems Architecture detection
Date: Thu, 10 Apr 2008 08:42:00 -0600 [thread overview]
Message-ID: <20080410144200.GF13663@cosmic.amd.com> (raw)
In-Reply-To: <20080410094024.5111e108@ephemeral>
On 10/04/08 09:40 -0400, Andres Salomon wrote:
> On Thu, 10 Apr 2008 09:10:57 +0100
> Alan Cox <alan@lxorguk.ukuu.org.uk> wrote:
>
> > On Wed, 9 Apr 2008 22:33:28 -0400
> > Andres Salomon <dilinger@queued.net> wrote:
> >
> > >
> > > This is generic VSA detection. It's used by OLPC to determine whether or
> > > not the BIOS contains VSA, but since other BIOSes are coming out that don't
> > > use the VSA (ie, tinybios), it might end up being useful for others.
> >
> > NAK - but minor
> >
> > This is a check for *VSA2* which is not the same as VSA1 (Cyrix one) and
> > for older systems that actually matters as you may have VSA1 or VSA2 and
> > they are detected differently.
> >
>
> Excellent point. Can we extend this to check for a VSA1-specific
> string, or does VSA1 not have a similar signature?
I don't think we need to worry about it. 99.99% of Geode systems run
with VSA happily transparent in the background, and thus would have no
good reason to check for it. Certainly, there are no processors with VSA1
that would care to check.
But Alan does have a good point - we should name it vsa2 for
strict correctness.
Jordan
--
Jordan Crouse
Systems Software Development Engineer
Advanced Micro Devices, Inc.
prev parent reply other threads:[~2008-04-10 14:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 2:33 [PATCH 2/3] x86: GEODE: add Virtual Systems Architecture detection Andres Salomon
2008-04-10 8:10 ` Alan Cox
2008-04-10 13:40 ` Andres Salomon
2008-04-10 14:20 ` Alan Cox
2008-04-11 1:53 ` Andres Salomon
2008-04-10 14:42 ` Jordan Crouse [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080410144200.GF13663@cosmic.amd.com \
--to=jordan.crouse@amd.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=dilinger@queued.net \
--cc=info-linux@geode.amd.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox