From: Rodolfo Giometti <giometti@enneenne.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
David Woodhouse <dwmw2@infradead.org>,
Dave Jones <davej@redhat.com>, Sam Ravnborg <sam@ravnborg.org>,
Greg KH <greg@kroah.com>, Randy Dunlap <randy.dunlap@oracle.com>,
Kay Sievers <kay.sievers@vrfy.org>
Subject: Re: [PATCH 5/7] PPS: serial clients support.
Date: Thu, 10 Apr 2008 17:36:59 +0200 [thread overview]
Message-ID: <20080410153659.GF26777@enneenne.com> (raw)
In-Reply-To: <20080410162812.39414ec5@core>
On Thu, Apr 10, 2008 at 04:28:12PM +0100, Alan Cox wrote:
> On Thu, 10 Apr 2008 17:15:58 +0200
> Rodolfo Giometti <giometti@linux.it> wrote:
>
> > Adds support for the PPS sources connected with the CD (Carrier
> > Detect) pin of a serial port.
>
> Ok why does this need to hack the driver layer ?
>
> > -static void uart_change_speed(struct uart_state *state,
> > - struct ktermios *old_termios);
> > +static void uart_change_speed(struct uart_state *state, struct ktermios *old_termios);
>
> NAK. Please remove random formatting changes
Sorry, this patch is wrong! I'll re-submit the right code. '-_-
Thanks,
Rodolfo
--
GNU/Linux Solutions e-mail: giometti@enneenne.com
Linux Device Driver giometti@linux.it
Embedded Systems phone: +39 349 2432127
UNIX programming skype: rodolfo.giometti
next prev parent reply other threads:[~2008-04-10 15:37 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-10 15:15 LinuxPPS (RESUBMIT 3): the PPS Linux implementation Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 1/7] LinuxPPS core support Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 2/7] PPS: userland header file for PPS API Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 3/7] PPS: documentation programs and examples Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 4/7] PPS: LinuxPPS clients support Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 5/7] PPS: serial " Rodolfo Giometti
2008-04-10 15:15 ` [PATCH 6/7] PPS: example program to enable PPS support on serial ports Rodolfo Giometti
2008-04-10 15:16 ` [PATCH 7/7] PPS: parallel port clients support Rodolfo Giometti
2008-04-10 15:28 ` [PATCH 5/7] PPS: serial " Alan Cox
2008-04-10 15:36 ` Rodolfo Giometti [this message]
2008-04-10 15:28 ` LinuxPPS (RESUBMIT 3): the PPS Linux implementation Lennart Sorensen
-- strict thread matches above, loose matches on Subject: below --
2008-04-10 16:01 [PATCH 5/7] PPS: serial clients support Rodolfo Giometti
2008-04-10 16:06 ` Rodolfo Giometti
2008-04-10 17:41 ` Greg KH
2008-04-10 18:22 ` LinuxPPS (RESUBMIT 4): the PPS Linux implementation Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 1/7] LinuxPPS core support Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 2/7] PPS: userland header file for PPS API Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 3/7] PPS: documentation programs and examples Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 4/7] PPS: LinuxPPS clients support Rodolfo Giometti
2008-04-10 18:22 ` [PATCH 5/7] PPS: serial " Rodolfo Giometti
2008-04-10 20:09 ` Alan Cox
2008-04-11 7:55 ` Rodolfo Giometti
2008-04-11 8:28 ` Alan Cox
2008-04-11 8:49 ` Rodolfo Giometti
2008-04-11 14:43 ` Serge Belyshev
2008-04-11 16:58 ` Rodolfo Giometti
2008-04-11 13:47 ` Lennart Sorensen
2008-04-11 14:46 ` Alan Cox
2008-04-30 11:41 ` Rodolfo Giometti
2008-04-30 16:28 ` Alan Cox
2008-05-02 7:33 ` Rodolfo Giometti
2008-05-02 10:18 ` Alan Cox
2008-05-02 10:45 ` Rodolfo Giometti
2008-05-02 12:56 ` Alan Cox
2008-05-02 21:09 ` Rodolfo Giometti
2008-03-06 12:08 LinuxPPS (RESUBMIT 2): the PPS Linux implementation Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 1/7] LinuxPPS core support Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 2/7] PPS: userland header file for PPS API Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 3/7] PPS: documentation programs and examples Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 4/7] PPS: LinuxPPS clients support Rodolfo Giometti
2008-03-06 12:09 ` [PATCH 5/7] PPS: serial " Rodolfo Giometti
2008-03-20 20:04 ` Andrew Morton
2008-03-21 11:17 ` Rodolfo Giometti
2008-03-21 17:41 ` Andrew Morton
2008-03-25 10:38 ` Rodolfo Giometti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080410153659.GF26777@enneenne.com \
--to=giometti@enneenne.com \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=kay.sievers@vrfy.org \
--cc=linux-kernel@vger.kernel.org \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox