From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758183AbYDJSEm (ORCPT ); Thu, 10 Apr 2008 14:04:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756299AbYDJSEb (ORCPT ); Thu, 10 Apr 2008 14:04:31 -0400 Received: from palinux.external.hp.com ([192.25.206.14]:50400 "EHLO mail.parisc-linux.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756028AbYDJSEa (ORCPT ); Thu, 10 Apr 2008 14:04:30 -0400 Date: Thu, 10 Apr 2008 12:04:13 -0600 From: Matthew Wilcox To: Grant Grundler Cc: Linus Torvalds , Krzysztof Halasa , Frans Pop , Ingo Molnar , jeff@garzik.org, auke-jan.h.kok@intel.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, e1000-devel@lists.sourceforge.net, linux-pci@atrey.karlin.mff.cuni.cz, akpm@linux-foundation.org, davem@davemloft.net, jesse.brandeburg@intel.com, john.ronciak@intel.com, bruce.w.allan@intel.com, greg@kroah.com, arjan@linux.intel.com, rjw@sisk.pl Subject: Re: [patch] e1000=y && e1000e=m regression fix (was: Re: [regression] e1000e broke e1000) Message-ID: <20080410180412.GV11962@parisc-linux.org> References: <20080408203314.GA28952@elte.hu> <47FBDBE9.9040700@garzik.org> <47FBDBE9.9040700@garzik.org> <20080409193850.GA11763@elte.hu> <200804092249.23111.elendil@planet.nl> <20080410175503.GA11440@colo.lackof.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080410175503.GA11440@colo.lackof.org> User-Agent: Mutt/1.5.13 (2006-08-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Apr 10, 2008 at 11:55:03AM -0600, Grant Grundler wrote: > Agreed. I like Ingo's Kconfig patch which forces both drivers > (e1000 and e1000e) to be built the same way (ie both modules or both > builtin). Uh, that's /not/ what Ingo's patch does. His patch makes e1000 claim the e1000e IDs if e1000 is built-in and e1000e is a module. -- Intel are signing my paycheques ... these opinions are still mine "Bill, look, we understand that you're interested in selling us this operating system, but compare it to ours. We can't possibly take such a retrograde step."