From: Andrew Morton <akpm@linux-foundation.org>
To: Randy Dunlap <randy.dunlap@oracle.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
sam@ravnborg.org, Ingo Molnar <mingo@elte.hu>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v2] documentation: build source files in Documentation sub-dir
Date: Thu, 10 Apr 2008 18:11:53 -0700 [thread overview]
Message-ID: <20080410181153.92a5724d.akpm@linux-foundation.org> (raw)
In-Reply-To: <20080410175630.d862af9e.randy.dunlap@oracle.com>
On Thu, 10 Apr 2008 17:56:30 -0700 Randy Dunlap <randy.dunlap@oracle.com> wrote:
> On Wed, 9 Apr 2008 14:54:09 -0700 Andrew Morton wrote:
>
> > make allmodconfig
> > gcc -I$(/bin/pwd)/include Documentation/accounting/getdelays.c -o getdelays
> >
> > In file included from /usr/src/devel/include/linux/netlink.h:5,
> > from /usr/src/devel/include/linux/genetlink.h:4,
> > from Documentation/accounting/getdelays.c:26:
> > /usr/src/devel/include/linux/types.h:203: error: expected specifier-qualifier-list before '__kernel_daddr_t'
>
>
> Those __kernel_* types shouldn't be used outside of the #ifdef __KERNEL__
> block, should they?
>
> Patch below fixes kernel side for me. Don't have any idea what it
> may do to userspace users of the header file.
>
> ---
> include/linux/types.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> --- mmotm-2008-0410-0157.orig/include/linux/types.h
> +++ mmotm-2008-0410-0157/include/linux/types.h
> @@ -200,8 +200,8 @@ typedef u32 resource_size_t;
> #endif /* __KERNEL__ */
>
> struct ustat {
> - __kernel_daddr_t f_tfree;
> - __kernel_ino_t f_tinode;
> + daddr_t f_tfree;
> + ino_t f_tinode;
> char f_fname[6];
> char f_fpack[6];
> };
hm.
It'd be nice to know how git-x86 managed to make this happen. I haven't
looked, apart from noting that it doesn't seem to touch any of the relevant
files.
next prev parent reply other threads:[~2008-04-11 1:14 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-03 19:45 [PATCH] documentation: build source files in Documentation sub-dir Randy Dunlap
2008-04-08 20:46 ` Andrew Morton
2008-04-09 19:35 ` [PATCH v2] " Randy Dunlap
2008-04-09 21:54 ` Andrew Morton
2008-04-11 0:56 ` Randy Dunlap
2008-04-11 1:11 ` Andrew Morton [this message]
2008-04-13 14:05 ` Thomas Gleixner
2008-04-09 22:52 ` Nick Andrew
2008-04-09 23:53 ` Randy Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080410181153.92a5724d.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=randy.dunlap@oracle.com \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox