Re: [BUG] linux-next: Tree for April 10 - kernel panic while loading ata driver on powermac

[Bartlomiej Zolnierkiewicz <bzolnier@gmail.com>]

On Thursday 10 April 2008, Bartlomiej Zolnierkiewicz wrote:
> Hi,
> 
> On Thu, Apr 10, 2008 at 12:24 PM, Kamalesh Babulal
> <kamalesh@linux.vnet.ibm.com> wrote:
> > Hi Stephen,
> >
> >  The next-20080410 kernel panics while bootup over the PowerMac G5 box, while
> >  loading the ATA driver.
> >
> >  [    3.704000] Faulting instruction address: 0xc0000000000222a8
> >  [    3.704000] Oops: Kernel access of bad area, sig: 11 [#1]
> >  [    3.704000] SMP NR_CPUS=32 NUMA PowerMac
> >  [    3.704000] Modules linked in:
> >  [    3.704000] NIP: c0000000000222a8 LR: c00000000021cd10 CTR: 0000000000000100
> >  [    3.704000] REGS: c0000002760db070 TRAP: 0300   Not tainted  (2.6.25-rc8-next-20080410-autokern1)
> >  [    3.704000] MSR: 9000000000009032 <EE,ME,IR,DR>  CR: 44000042  XER: 20000000
> >  [    3.704000] DAR: a0001000822fa000, DSISR: 0000000040000000
> >  [    3.704000] TASK = c0000002760d7100[1] 'swapper' THREAD: c0000002760d8000 CPU: 0
> >  [    3.704000] GPR00: 0000000000000100 c0000002760db2f0 c000000000498310 a0001000822fa000
> >  [    3.704000] GPR04: c000000274806a00 0000000000000100 0000000000000201 c00000000000fed4
> >  [    3.704000] GPR08: c0000002760daf20 c0000000003ee0d8 c0000000004f1428 0000000000000000
> >  [    3.704000] GPR12: 0000000000000000 c0000000003fa700 0000000000000000 0000000000000000
> >  [    3.704000] GPR16: 0000000000000000 0000000000000000 0000000000000000 0000000000000000
> >  [    3.704000] GPR20: 0000000000000001 0000000000000027 0000000000000027 0000000000000000
> >  [    3.704000] GPR24: c0000000004f1400 0000000000000000 0000000000000201 c0000000004f1490
> >  [    3.704000] GPR28: a0001000822fa000 0000000000000200 c00000000044cf50 c000000274806a00
> >  [    3.704000] NIP [c0000000000222a8] ._insw_ns+0x10/0x30
> >  [    3.704000] LR [c00000000021cd10] .ata_input_data+0x1f4/0x264
> 
> Could you please add printk() for 'hwif->host_flags', 'mmio' and 'io_32bit'
> to ide-iops.c::ata_input_data() so we know more on what is going on?

No longer needed - please test the hot-fix below instead:

---
thanks to Andrew for noticing me about the gcc warning

 drivers/ide/ppc/pmac.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Index: b/drivers/ide/ppc/pmac.c
===================================================================
--- a/drivers/ide/ppc/pmac.c
+++ b/drivers/ide/ppc/pmac.c
@@ -941,7 +941,7 @@ static const struct ide_port_info pmac_p
 	.port_ops		= &pmac_ide_port_ops,
 	.host_flags		= IDE_HFLAG_SET_PIO_MODE_KEEP_DMA |
 				  IDE_HFLAG_POST_SET_MODE |
-				  IDE_HFLAG_UNMASK_IRQS,
+				  IDE_HFLAG_UNMASK_IRQS |
 				  IDE_HFLAG_MMIO,
 	.pio_mask		= ATA_PIO4,
 	.mwdma_mask		= ATA_MWDMA2,