public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <Uwe.Kleine-Koenig@digi.com>
To: David Brownell <dbrownell@users.sourceforge.net>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] GPIO: #include <linux/kernel.h> for might_sleep
Date: Fri, 11 Apr 2008 12:46:04 +0200	[thread overview]
Message-ID: <20080411104604.GA19973@digi.com> (raw)
In-Reply-To: <1207902290-25381-1-git-send-email-Uwe.Kleine-Koenig@digi.com>

Hello again,

Uwe Kleine-König wrote:
> Signed-off-by: Uwe Kleine-König <Uwe.Kleine-Koenig@digi.com>
> ---
> Hello David,
> 
> I like having headers being independend of the order of inclusion.
> Usually I order all includes alphabetically (and grouped by linux/,
> asm/, etc.).  This doesn't work with gpio.h because then kernel.h is
> included to late.
I just noticed that you need include/asm/types.h also for the
CONFIG_HAVE_GPIO_LIB=y case.  So the #include can better go to the top
of include/asm-generic/gpio.h.

I won't send a new version untill you say if it's OK for you to add
#includes to that header.

Best regards
Uwe

-- 
Uwe Kleine-König, Software Engineer
Digi International GmbH Branch Breisach, Küferstrasse 8, 79206 Breisach, Germany
Tax: 315/5781/0242 / VAT: DE153662976 / Reg. Amtsgericht Dortmund HRB 13962

  reply	other threads:[~2008-04-11 10:47 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11  8:24 [PATCH] GPIO: #include <linux/kernel.h> for might_sleep Uwe Kleine-König
2008-04-11 10:46 ` Uwe Kleine-König [this message]
2008-04-11 17:05 ` David Brownell
2008-04-15  7:36   ` Uwe Kleine-König

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080411104604.GA19973@digi.com \
    --to=uwe.kleine-koenig@digi.com \
    --cc=dbrownell@users.sourceforge.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox