From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760057AbYDKKvb (ORCPT ); Fri, 11 Apr 2008 06:51:31 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1758952AbYDKKvY (ORCPT ); Fri, 11 Apr 2008 06:51:24 -0400 Received: from mx3.mail.elte.hu ([157.181.1.138]:46623 "EHLO mx3.mail.elte.hu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758939AbYDKKvX (ORCPT ); Fri, 11 Apr 2008 06:51:23 -0400 Date: Fri, 11 Apr 2008 12:51:09 +0200 From: Ingo Molnar To: Pavel Machek Cc: Jiri Kosina , "Rafael J. Wysocki" , Andi Kleen , Zdenek Kabelac , Kernel development list , Thomas Gleixner Subject: Re: BUG: using smp_processor_id() during suspend with 2.6.25-rc8 Message-ID: <20080411105108.GA1844@elte.hu> References: <20080407222352.GG16647@one.firstfloor.org> <200804080029.31102.rjw@sisk.pl> <20080410094554.GA10321@ucw.cz> <20080411104902.GA8734@elf.ucw.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080411104902.GA8734@elf.ucw.cz> User-Agent: Mutt/1.5.17 (2007-11-01) X-ELTE-VirusStatus: clean X-ELTE-SpamScore: -1.5 X-ELTE-SpamLevel: X-ELTE-SpamCheck: no X-ELTE-SpamVersion: ELTE 2.0 X-ELTE-SpamCheck-Details: score=-1.5 required=5.9 tests=BAYES_00 autolearn=no SpamAssassin version=3.2.3 -1.5 BAYES_00 BODY: Bayesian spam probability is 0 to 1% [score: 0.0000] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org * Pavel Machek wrote: > diff --git a/lib/smp_processor_id.c b/lib/smp_processor_id.c > index 6c90fb9..8195c37 100644 > --- a/lib/smp_processor_id.c > +++ b/lib/smp_processor_id.c > @@ -35,6 +35,13 @@ unsigned int debug_smp_processor_id(void > goto out; > > /* > + * It is valid to assume CPU-locality if there's just one > + * CPU active > + */ > + if (num_online_cpus() == 1) > + goto out; thanks Pavel, i picked this up into sched-devel.git - it makes sense independently of whether it solves the warning. Ingo