From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760938AbYDKP1f (ORCPT ); Fri, 11 Apr 2008 11:27:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1760026AbYDKP1N (ORCPT ); Fri, 11 Apr 2008 11:27:13 -0400 Received: from ogre.sisk.pl ([217.79.144.158]:55763 "EHLO ogre.sisk.pl" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759960AbYDKP1M (ORCPT ); Fri, 11 Apr 2008 11:27:12 -0400 From: "Rafael J. Wysocki" To: Andi Kleen Subject: Re: BUG: using smp_processor_id() during suspend with 2.6.25-rc8 Date: Fri, 11 Apr 2008 17:27:32 +0200 User-Agent: KMail/1.9.6 (enterprise 20070904.708012) Cc: Ingo Molnar , Pavel Machek , Jiri Kosina , Zdenek Kabelac , Kernel development list , Thomas Gleixner References: <20080411105108.GA1844@elte.hu> <20080411113746.GV10019@one.firstfloor.org> In-Reply-To: <20080411113746.GV10019@one.firstfloor.org> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200804111727.33922.rjw@sisk.pl> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Friday, 11 of April 2008, Andi Kleen wrote: > > thanks Pavel, i picked this up into sched-devel.git - it makes sense > > independently of whether it solves the warning. > > This means the CPU preempt sanity checking is effectively disabled > on UP kernels. Even though more and more people should run multi-core > now there is still a sizeable user base left on single core. > > Don't think this is a good idea. We need even the UP testers. Agreed. Besides, I'd like to learn what caused the problem to appear in the first place. > If he wants this for suspend or machine check/oops (always useful there > to disable such warnings) then there should > be separate checks for this. Perhaps system_state could be enhanced for this? That would make sense. Thanks, Rafael