From: Andrew Morton <akpm@linux-foundation.org>
To: Takenori Nagano <t-nagano@ah.jp.nec.com>
Cc: linux-kernel@vger.kernel.org, kdb@oss.sgi.com, vgoyal@in.ibm.com,
"Eric W. Biederman" <ebiederm@xmission.com>,
k-miyoshi@cb.jp.nec.com, kexec@lists.infradead.org,
Bernhard Walle <bwalle@suse.de>, Keith Owens <kaos@ocs.com.au>,
nickpiggin@yahoo.com.au, Randy Dunlap <rdunlap@xenotime.net>,
greg@kroah.com
Subject: Re: [PATCH 0/2] add new notifier function ,take3
Date: Fri, 11 Apr 2008 21:07:51 -0700 [thread overview]
Message-ID: <20080411210751.e4a468b2.akpm@linux-foundation.org> (raw)
In-Reply-To: <47FF190B.6030406@ah.jp.nec.com>
On Fri, 11 Apr 2008 16:53:47 +0900 Takenori Nagano <t-nagano@ah.jp.nec.com> wrote:
> Hi,
>
> A big thanks to everybody who read and replied to previous version.
>
> changelog take2 -> take3
>
> - Rebased 2.6.25-rc8-mm1
> - comment updated
> - renamed the notifiner name "tunable_notifier" to "tunable_atomic_notifier"
> - fixed typo
> - move control files debugfs to /sys/kernel
>
> These patches add new notifier function and implement it to panic_notifier_list.
> We used the hardcoded notifier chain so far, but it was not flexible. New
> notifier is very flexible, because user can change a list of order by control files.
>
> Example)
>
> # cd /sys/kernel/notifiers/
> # ls
> panic_notifier_list
> # cd panic_notifier_list/
> # ls
> ipmi_msghandler ipmi_wdog
> # insmod notifier_test.ko
> # ls
> ipmi_msghandler ipmi_wdog notifier_test1 notifier_test2
> # cat */priority
> 200
> 150
> 500
> 1000
> Kernel panic - not syncing: Panic by panic_module.
> __tunable_atomic_notifier_call_chain enter
> notifier_test: notifier_test_panic2() is called.
> notifier_test: notifier_test_panic() is called.
> msg_handler:panic_event was called.
> ipmi_wdog:wdog_panic_handler was called.
>
> .....(reboot)
>
> # cd /sys/kernel/notifiers/panic_notifier_list/
> # ls
> ipmi_msghandler ipmi_wdog notifier_test1 notifier_test2
> # cat */priority
> 200
> 150
> 500
> 1000
> # echo 10000 > ipmi_msghandler/priority
> # echo 5000 > ipmi_wdog/priority
> # echo 3000 > notifier_test1/priority
> # echo 1500 > notifier_test2/priority
> # cat */priority
> 10000
> 5000
> 3000
> 1500
> Kernel panic - not syncing: Panic by panic_module.
> __tunable_atomic_notifier_call_chain enter
> msg_handler:panic_event was called.
> ipmi_wdog:wdog_panic_handler was called.
> notifier_test: notifier_test_panic() is called.
> notifier_test: notifier_test_panic2() is called.
OK. But I don't see anywhere in here the most important piece of
information: why do we need this feature in Linux?
What are the use-cases? What is the value? etc.
Often I can guess (but I like the originator to remove the guesswork). In
this case I'm stumped - I can't see any reason why anyone would want this.
Awaiting enlightenment ;)
Thanks.
next prev parent reply other threads:[~2008-04-12 4:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-11 7:53 [PATCH 0/2] add new notifier function ,take3 Takenori Nagano
2008-04-12 4:07 ` Andrew Morton [this message]
2008-04-14 13:46 ` Vivek Goyal
2008-04-14 14:42 ` Neil Horman
2008-04-14 14:46 ` Bernhard Walle
2008-04-14 14:53 ` Vivek Goyal
2008-04-14 16:01 ` Neil Horman
2008-04-14 19:33 ` Andrew Morton
2008-04-17 5:31 ` Takenori Nagano
2008-04-23 12:31 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080411210751.e4a468b2.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=bwalle@suse.de \
--cc=ebiederm@xmission.com \
--cc=greg@kroah.com \
--cc=k-miyoshi@cb.jp.nec.com \
--cc=kaos@ocs.com.au \
--cc=kdb@oss.sgi.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nickpiggin@yahoo.com.au \
--cc=rdunlap@xenotime.net \
--cc=t-nagano@ah.jp.nec.com \
--cc=vgoyal@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox