Re: [GIT PATCH] rfkill support for r/w and r/o rfkill switches

[Ivo van Doorn <ivdoorn@gmail.com>]

Hi,

> This patch series (based on v2.6.25-rc8-mm2) has several improvements to
> the rfkill class that I need for thinkpad-acpi, plus two fluff and
> documentation fixes.
> 
> I'd appreciate comments, and if the patches are acceptable, that they are
> sent to mainline early during the 2.6.26 merge window.  That way, I could
> try for a thinkpad-acpi rfkill submission for 2.6.26 as well.
> 
> The thinkpad-acpi work that needs these patches is ready, and can be
> looked at on the thinkpad-acpi git tree (devel branch):
> http://repo.or.cz/w/linux-2.6/linux-acpi-2.6/ibm-acpi-2.6.git
> 
> Note: new thinkpads have a read-only "type any" radio switch, plus
> read-write WWAN and Bluetooth radio switches.   The embedded WLAN cards
> have WLAN read-write switches (that should be handled by the ipw* and iwl*
> drivers).  Very old thinkpads had ACPI-based WLAN radio switches, but
> thinkpad-acpi does not support those.

The following patches are fine by me, without any additional comments:
[PATCH 1/8] rfkill: clarify meaning of rfkill states
[PATCH 2/8] rfkill: fix minor typo in kernel doc
[PATCH 5/8] rfkill: add read-only rfkill switch support
[PATCH 7/8] rfkill: add an "any radio" switch type and functionality

The following patches are overall fine, but I have some additional comments:
[PATCH 6/8] rfkill: add the WWAN radio type
[PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events

The following patches are _not_ fine with me:
[PATCH 4/8] rfkill: add read-write rfkill switch support
[PATCH 8/8] rfkill: add parameter to disable radios by default

Ivo