From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756301AbYDLRdi (ORCPT ); Sat, 12 Apr 2008 13:33:38 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754529AbYDLRdb (ORCPT ); Sat, 12 Apr 2008 13:33:31 -0400 Received: from e4.ny.us.ibm.com ([32.97.182.144]:48829 "EHLO e4.ny.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754455AbYDLRda (ORCPT ); Sat, 12 Apr 2008 13:33:30 -0400 Date: Sat, 12 Apr 2008 10:32:02 -0700 From: sukadev@us.ibm.com To: Andrew Morton Cc: serue@us.ibm.com, matthltc@us.ibm.com, "Eric W. Biederman" , hpa@zytor.com, Pavel Emelyanov , Containers , linux-kernel@vger.kernel.org Subject: [PATCH 1/4]: Propagate error code from devpts_pty_new Message-ID: <20080412173202.GA19449@us.ibm.com> References: <20080412172933.GA19295@us.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20080412172933.GA19295@us.ibm.com> X-Operating-System: Linux 2.0.32 on an i486 User-Agent: Mutt/1.5.15+20070412 (2007-04-11) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Sukadev Bhattiprolu Subject: [PATCH 1/4]: Propagate error code from devpts_pty_new Have ptmx_open() propagate any error code returned by devpts_pty_new() (which returns either 0 or -ENOMEM anyway). Signed-off-by: Sukadev Bhattiprolu --- drivers/char/tty_io.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) Index: 2.6.25-rc8-mm1/drivers/char/tty_io.c =================================================================== --- 2.6.25-rc8-mm1.orig/drivers/char/tty_io.c 2008-04-07 14:49:56.000000000 -0700 +++ 2.6.25-rc8-mm1/drivers/char/tty_io.c 2008-04-09 13:54:00.000000000 -0700 @@ -2835,8 +2835,8 @@ static int ptmx_open(struct inode *inode filp->private_data = tty; file_move(filp, &tty->tty_files); - retval = -ENOMEM; - if (devpts_pty_new(tty->link)) + retval = devpts_pty_new(tty->link); + if (retval) goto out1; check_tty_count(tty, "tty_open");