Re: [PATCH 3/8] rfkill: handle KEY_RADIO and SW_RADIO events

[Ivo van Doorn <ivdoorn@gmail.com>]

On Saturday 12 April 2008, Henrique de Moraes Holschuh wrote:
> On Sat, 12 Apr 2008, Dmitry Torokhov wrote:
> > On Fri, Apr 11, 2008 at 05:37:19PM -0300, Henrique de Moraes Holschuh wrote:
> > > The *_RADIO input events are related to all radios in a system.  There are
> > > two: KEY_RADIO and SW_RADIO.
> > > 
> > 
> > KEY_RADIO is reserved for selecting radio input (as pooosed to TV, AUX,
> > etc) with a remote control. Rfkill woudl need a separate keycode if it
> > needs "all types of radios" event.
> 
> Hmm, let me check where I got the wrong idea of using KEY_RADIO from,
> because thinkpad-acpi already uses KEY_WLAN which means that at least in
> the past I did know KEY_RADIO was not to be used for wireless data
> communication devices like that...  jeez, looks like spontaneous brain
> corruption on that topic hapenned to me sometime ago, and it came out in
> a linux-thinkpad thread a few weeks ago.  The wrong semanthics for
> KEY_RADIO seem to have stuck to my mind since then.  Drat, I *really*
> apologise for this one.
> 
> This, of course, is a major NAK for this patch.  And I am considering
> dropping the handling of KEY_<whatever replaces RADIO> completely from
> it.  SW_RADIO (after a rename, see below) still needs to be handled,
> though.
> 
> > Btw, is there any devices in the wild that actually have separate
> > switches for different types of transmitters?
> 
> Separate switches?  I know of none.
> 
> Separate hot keys/buttons?  I haven't seen it, but check commit
> 90da11514562020ea7d697982f912ac949adc317's comment.  That was the commit
> which added KEY_WLAN and KEY_BLUETOOTH, back in 2.6.18-rc.  Maybe ask
> Lennart Poettering about it?

My laptop (Acer Ferrari 3200) features 2 keys, 1 for 802.11 and 1 for Bluetooth.
Both directly communicate to the hardware itself and only need rfkill for
notification purposes to userspace.

Ivo