From: David Miller <davem@davemloft.net>
To: vda.linux@googlemail.com
Cc: chas@cmf.nrl.navy.mil, kernel-janitors@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drivers/atm/horizon.c: stop inlining largish static functions
Date: Sun, 13 Apr 2008 21:54:52 -0700 (PDT) [thread overview]
Message-ID: <20080413.215452.31407494.davem@davemloft.net> (raw)
In-Reply-To: <200804081221.42465.vda.linux@googlemail.com>
From: Denys Vlasenko <vda.linux@googlemail.com>
Date: Tue, 8 Apr 2008 12:21:42 +0200
> drivers/atm/horizon.c has unusually large number
> of static inline functions - 36.
>
> I looked through them. Most of them seems to be small enough,
> but a few are big, others are using udelay or busy loop,
> and as such are better not be inlined.
>
> This patch removes "inline" from these static functions
> (regardless of number of callsites - gcc nowadays auto-inlines
> statics with one callsite).
>
> Size difference for 32bit x86:
> text data bss dec hex filename
> 8201 180 6 8387 20c3 linux-2.6-ALLYES/drivers/atm/horizon.o
> 7840 180 6 8026 1f5a linux-2.6.inline-ALLYES/drivers/atm/horizon.o
>
> Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Applied to net-2.6.26, thanks Denys.
prev parent reply other threads:[~2008-04-14 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-08 10:21 [PATCH] drivers/atm/horizon.c: stop inlining largish static functions Denys Vlasenko
2008-04-14 4:54 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080413.215452.31407494.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=chas@cmf.nrl.navy.mil \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vda.linux@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox