From: Ingo Molnar <mingo@elte.hu>
To: Nick Andrew <nick@nick-andrew.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
joe@perches.com, Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] printk: Remember the message level for multi-line output
Date: Sun, 13 Apr 2008 09:40:07 +0200 [thread overview]
Message-ID: <20080413074007.GE20332@elte.hu> (raw)
In-Reply-To: <20080412161733.24882.30930.stgit@marcab.local.tull.net>
* Nick Andrew <nick@nick-andrew.net> wrote:
> Modify vprintk() to remember the message loglevel each time it is
> specified and use it for subsequent lines of output which do not
> specify one, within the same call to printk.
>
> Restructure the logic so the processing of the leading 3 characters of
> each input line is in one place, regardless whether printk_time is
> enabled.
hm, i'm not sure about the change itself (printks are often random, so
the output to the console would depend on printk ordering), but the
combined effect seems to be a nice cleanup that reduces the linecount:
> 1 files changed, 27 insertions(+), 34 deletions(-)
so how about splitting it into two, first the code restructuring then a
small add-on that does your feature? Does this make sense to you? This
way, even if the feature ends up not being applied, we'll have your nice
cleanup :-)
Ingo
next prev parent reply other threads:[~2008-04-13 7:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-12 16:18 [PATCH] printk: Remember the message level for multi-line output Nick Andrew
2008-04-12 16:42 ` Nick Andrew
2008-04-13 7:40 ` Ingo Molnar [this message]
2008-04-13 11:34 ` Nick Andrew
2008-04-13 11:57 ` Nick Andrew
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080413074007.GE20332@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nick@nick-andrew.net \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox