From: Al Viro <viro@ZenIV.linux.org.uk>
To: Benny Halevy <bhalevy@panasas.com>
Cc: Andy Whitcroft <apw@shadowen.org>,
Jan Engelhardt <jengelh@computergmbh.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
SL Baur <steve@xemacs.org>, Randy Dunlap <rdunlap@xenotime.net>,
Richard Knutsson <ricknu-0@student.ltu.se>,
Stefan Richter <stefanr@s5r6.in-berlin.de>
Subject: Re: [patch] checkpatch: relax spacing and line length
Date: Sun, 13 Apr 2008 16:18:45 +0100 [thread overview]
Message-ID: <20080413151845.GP9785@ZenIV.linux.org.uk> (raw)
In-Reply-To: <4801D82C.7000901@panasas.com>
On Sun, Apr 13, 2008 at 12:53:48PM +0300, Benny Halevy wrote:
> > Sorry. I'm not going to change perfectly working editing habits *or* to patch
>
> That's working well for you but apparently not so well for everybody else.
Nice turn of a phrase, that.
> > nvi to satisfy an annoying wunch of bankers. HAND, GAFL.
> > --
>
> Thanks for the insightful and mature comment, Al.
Oh, for the...
> I really hate to spend more time on this topic but folks did find merits in it.
> There's no need to change anybody's editing habits if we allow this indentation
> style in the CodingStyle document and in checkpatch.pl in addition to the
> existing convention.
"Allow" is such a nice word, isn't it? Let's take a closer look:
* nobody prohibits lines satisfying your constraints ("tabs only for
indent level"), so "allowing" that is meaningless
* "indentation style" in the above refers to editor settings.
To "allow" that, you advocate prohibiting the lines _NOT_ satisfying your
constraints. Which, by definition, means extra work for people submitting
patches, no matter how you spin it.
BTW, while we are talking about conventions, would you mind keeping lines
in your mail shorter than 79 columns to avoid wraparounds in quoted text?
Unlike your proposal, that one actually _is_ a common convention...
next prev parent reply other threads:[~2008-04-13 15:19 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-06 4:54 [patch] checkpatch: relax spacing and line length Jan Engelhardt
2008-04-06 5:18 ` Andrew Morton
2008-04-06 11:52 ` Benny Halevy
2008-04-06 18:52 ` Joe Perches
2008-04-07 9:51 ` Boaz Harrosh
2008-04-06 10:08 ` Adrian Bunk
2008-04-06 11:08 ` Sam Ravnborg
2008-04-07 16:37 ` Benny Halevy
2008-04-08 17:12 ` Andy Whitcroft
2008-04-08 18:01 ` Andi Kleen
2008-04-09 8:19 ` Andy Whitcroft
2008-04-09 8:30 ` Andy Whitcroft
2008-04-09 8:46 ` Andi Kleen
2008-04-09 13:14 ` Andy Whitcroft
2008-04-09 13:18 ` Jan Engelhardt
2008-04-09 13:58 ` Andy Whitcroft
2008-04-09 16:53 ` Andrew Morton
2008-04-09 17:43 ` Andi Kleen
2008-04-09 20:07 ` Andy Whitcroft
2008-04-11 15:54 ` Andy Whitcroft
2008-04-09 15:14 ` Randy Dunlap
2008-04-09 12:10 ` Benny Halevy
2008-04-09 12:19 ` Benny Halevy
2008-04-09 13:25 ` Andy Whitcroft
2008-04-09 17:02 ` Benny Halevy
2008-04-09 17:27 ` Stefan Richter
2008-04-09 20:16 ` Andy Whitcroft
2008-04-10 23:52 ` SL Baur
2008-04-11 4:24 ` Jan Engelhardt
2008-04-12 0:26 ` Al Viro
2008-04-13 9:53 ` Benny Halevy
2008-04-13 15:18 ` Al Viro [this message]
2008-04-15 9:09 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080413151845.GP9785@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=akpm@linux-foundation.org \
--cc=apw@shadowen.org \
--cc=bhalevy@panasas.com \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rdunlap@xenotime.net \
--cc=ricknu-0@student.ltu.se \
--cc=stefanr@s5r6.in-berlin.de \
--cc=steve@xemacs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).