From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759090AbYDNGUN (ORCPT ); Mon, 14 Apr 2008 02:20:13 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753647AbYDNGUA (ORCPT ); Mon, 14 Apr 2008 02:20:00 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:41917 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752645AbYDNGT7 (ORCPT ); Mon, 14 Apr 2008 02:19:59 -0400 Date: Mon, 14 Apr 2008 02:19:58 -0400 From: Christoph Hellwig To: Davide Libenzi Cc: Linux Kernel Mailing List , Linus Torvalds , Andrew Morton , Al Viro Subject: Re: [patch] F_GETPATH for linux Message-ID: <20080414061958.GA21202@infradead.org> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Apr 13, 2008 at 03:00:53PM -0700, Davide Libenzi wrote: > I was working on some bsd/linux compatibility code, and I noticed that we > do not have F_GETPATH. I know we can readlink /proc/PID/fd/FD (that is > what I'm doing now, under #ifdef), but I gave a patch a shot anyway. > Here it is, building but untested ... Adding a duplicated API like this is rather pointless. Especially as the readlink is easier and makes more sense.