From: Ingo Molnar <mingo@elte.hu>
To: Heiko Carstens <heiko.carstens@de.ibm.com>
Cc: Peter Zijlstra <peterz@infradead.org>,
Miles Lane <miles.lane@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
Gautham Shenoy <ego@in.ibm.com>,
"Rafael J. Wysocki" <rjw@sisk.pl>,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: 2.6.25-rc9 -- INFO: possible circular locking dependency detected
Date: Mon, 14 Apr 2008 09:18:00 +0200 [thread overview]
Message-ID: <20080414071800.GE16163@elte.hu> (raw)
In-Reply-To: <20080414070234.GA7482@osiris.boeblingen.de.ibm.com>
* Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> On Mon, Apr 14, 2008 at 08:54:05AM +0200, Peter Zijlstra wrote:
> > Fun,
> >
> > I will need to sort out this code before I can say anything about that,
> > perhaps Gautham and or Rafael have ideas before I can come up with
> > something.. ?
>
> Why not simply removing the get/put_online_cpus() pair in
> sched_getaffinity? It's superfluous since we have already a
> read_lock/read_unlock pair there which does disable/enable cpu hotplug
> anyway.
we dont want to insert such silent "preempt off == hotplug disable"
assumptions - which assumption breaks when the tasklist_lock becomes
preemptible (such as in -rt).
Ingo
next prev parent reply other threads:[~2008-04-14 7:18 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-14 3:04 2.6.25-rc9 -- INFO: possible circular locking dependency detected Miles Lane
2008-04-14 3:29 ` Miles Lane
2008-04-14 6:54 ` Peter Zijlstra
2008-04-14 7:02 ` Heiko Carstens
2008-04-14 7:18 ` Ingo Molnar [this message]
2008-04-14 12:06 ` Peter Zijlstra
2008-04-14 12:27 ` Gautham R Shenoy
2008-04-14 12:42 ` Peter Zijlstra
2008-04-14 13:28 ` Gautham R Shenoy
2008-04-14 14:48 ` Gautham R Shenoy
2008-04-14 15:19 ` Heiko Carstens
2008-04-14 15:46 ` Gautham R Shenoy
2008-04-14 19:35 ` Heiko Carstens
2008-04-15 13:52 ` Gautham R Shenoy
2008-04-15 14:37 ` Heiko Carstens
[not found] ` <20080422123304.GA777@osiris.boeblingen.de.ibm.com>
[not found] ` <1208868236.7115.249.camel@twins>
[not found] ` <20080423035802.GA8895@in.ibm.com>
[not found] ` <20080424150714.GA8273@osiris.boeblingen.de.ibm.com>
[not found] ` <1209052984.7115.369.camel@twins>
[not found] ` <20080424155946.GA11160@tv-sign.ru>
[not found] ` <20080424194810.GA4821@osiris.boeblingen.de.ibm.com>
[not found] ` <20080424192706.GA165@tv-sign.ru>
[not found] ` <20080425064044.GA10817@osiris.boeblingen.de.ibm.com>
2008-04-26 14:43 ` get_online_cpus() && workqueues Oleg Nesterov
2008-04-27 12:22 ` Heiko Carstens
2008-04-27 14:25 ` Oleg Nesterov
2008-04-28 7:02 ` Gautham R Shenoy
2008-04-28 10:56 ` Oleg Nesterov
2008-04-28 12:03 ` Gautham R Shenoy
2008-04-28 12:40 ` Oleg Nesterov
2008-04-28 11:57 ` Gautham R Shenoy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080414071800.GE16163@elte.hu \
--to=mingo@elte.hu \
--cc=ego@in.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=miles.lane@gmail.com \
--cc=peterz@infradead.org \
--cc=rjw@sisk.pl \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox