public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Vivek Goyal <vgoyal@redhat.com>
To: Neil Horman <nhorman@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	nickpiggin@yahoo.com.au, k-miyoshi@cb.jp.nec.com, greg@kroah.com,
	Bernhard Walle <bwalle@suse.de>,
	kdb@oss.sgi.com, kexec@lists.infradead.org,
	Takenori Nagano <t-nagano@ah.jp.nec.com>,
	linux-kernel@vger.kernel.org, Randy Dunlap <rdunlap@xenotime.net>,
	"Eric W. Biederman" <ebiederm@xmission.com>,
	Keith Owens <kaos@ocs.com.au>
Subject: Re: [PATCH 0/2] add new notifier function ,take3
Date: Mon, 14 Apr 2008 10:53:23 -0400	[thread overview]
Message-ID: <20080414145323.GE6941@redhat.com> (raw)
In-Reply-To: <20080414144228.GD1193@hmsendeavour.rdu.redhat.com>

On Mon, Apr 14, 2008 at 10:42:28AM -0400, Neil Horman wrote:
> On Mon, Apr 14, 2008 at 09:46:22AM -0400, Vivek Goyal wrote:
> > On Fri, Apr 11, 2008 at 09:07:51PM -0700, Andrew Morton wrote:
> > 
> > [..]
> > > > Kernel panic - not syncing: Panic by panic_module.
> > > > __tunable_atomic_notifier_call_chain enter
> > > > msg_handler:panic_event was called.
> > > > ipmi_wdog:wdog_panic_handler was called.
> > > > notifier_test: notifier_test_panic() is called.
> > > > notifier_test: notifier_test_panic2() is called.
> > > 
> > > OK.  But I don't see anywhere in here the most important piece of
> > > information: why do we need this feature in Linux?
> > > 
> > > What are the use-cases?  What is the value?  etc.
> > > 
> > > Often I can guess (but I like the originator to remove the guesswork).  In
> > > this case I'm stumped - I can't see any reason why anyone would want this.
> > > 
> > 
> > Hi Andrew,
> > 
> > To begin with, he wants kdb, kgdb etc to co-exist with kdump. He wants
> > to put all the RAS tools (who are interested in panic event) on a list
> > and export it to user space and let user decide in what order do the tool get
> > executed at panic time (based on priority).
> > 
> > This brings in little bit reliability concerns for kdump due to notifier
> > code being run after panic.
> > 
> > I think people want to use this infrastrutucure beyond RAS tools. I
> > remember somebody wanting to send a message to remote node after a
> > panic (before kdump kicks in)  so that remote node can initiate failover
> > etc.
> > 
> I know it doesn't particularly relate to this patch, but FWIW, for cases like
> failover, I've inserted infrastrucutre in the userspace part of kdump for
> Fedora/RHEL to support this sort of thing.  We can run arbitrary scripts righte
> before and after a capture so that notifications can be sent to remote nodes in
> a much safer fashion than using the notifier chain after a panic.
> Neil
> 

That's great. I did not know about these. So user can write custom
scripts/binaries which can be packed into kdump initrd and executed either
before or after dump capture? Any idea, if somebody has started using it
already?

If that's the case then only other serious user at this point of time
is kernel debugger (kdb, kgdb), which needs to run before kdump, in case
of panic. And Eric suggested for those cases debugger can just insert a 
break point at panic(), instead of introducing the tunable notifier list
infrastructure.

Thanks
Vivek

  parent reply	other threads:[~2008-04-14 14:54 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-11  7:53 [PATCH 0/2] add new notifier function ,take3 Takenori Nagano
2008-04-12  4:07 ` Andrew Morton
2008-04-14 13:46   ` Vivek Goyal
2008-04-14 14:42     ` Neil Horman
2008-04-14 14:46       ` Bernhard Walle
2008-04-14 14:53       ` Vivek Goyal [this message]
2008-04-14 16:01         ` Neil Horman
2008-04-14 19:33           ` Andrew Morton
2008-04-17  5:31             ` Takenori Nagano
2008-04-23 12:31               ` Eric W. Biederman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080414145323.GE6941@redhat.com \
    --to=vgoyal@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bwalle@suse.de \
    --cc=ebiederm@xmission.com \
    --cc=greg@kroah.com \
    --cc=k-miyoshi@cb.jp.nec.com \
    --cc=kaos@ocs.com.au \
    --cc=kdb@oss.sgi.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nhorman@redhat.com \
    --cc=nickpiggin@yahoo.com.au \
    --cc=rdunlap@xenotime.net \
    --cc=t-nagano@ah.jp.nec.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox